Tutorial on using ellipsoid actor to visualize tensor ellipsoids for DTI#818
Merged
Conversation
Contributor
|
Hey @tvcastillod, |
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
==========================================
- Coverage 84.33% 84.30% -0.04%
==========================================
Files 44 44
Lines 10356 10353 -3
Branches 1410 1406 -4
==========================================
- Hits 8734 8728 -6
- Misses 1252 1255 +3
Partials 370 370 |
tvcastillod
changed the title
tvcastillod
commented
Jul 24, 2023
skoudoro
reviewed
Jul 26, 2023
Contributor
skoudoro
left a comment
skoudoro
left a comment
There was a problem hiding this comment.
Nice Tutorial @tvcastillod.
- Please use
ShowManagereverywhere. - do not forget to add your tutorial in https://github.com/fury-gl/fury/blob/master/docs/examples/_valid_examples.toml
skoudoro
approved these changes
Aug 8, 2023
Contributor
skoudoro
left a comment
skoudoro
left a comment
There was a problem hiding this comment.
Excellent Tutorial ! Thank you @tvcastillod, this is great and explain well the difference.
I am going ahead and merge this PR. Thank you
Comment on lines
+58
to
+73
|
|
||
| class Sphere: | ||
| def __init__(self, vertices, faces): | ||
| self.vertices = vertices | ||
| self.faces = faces | ||
|
|
||
|
|
||
| sphere100 = Sphere(vertices, faces) | ||
|
|
||
| ############################################################################### | ||
| # Now we are ready to create the ``tensor_slicer`` actor with the values of a | ||
| # brain slice. We also define the scale so that the tensors are not so large | ||
| # and overlap each other. | ||
|
|
||
| tensor_slice = actor.tensor_slicer(evals=slice_evals, evecs=slice_evecs, | ||
| sphere=sphere100, scale=.3) |
Contributor
There was a problem hiding this comment.
Can you create an issue with this part of the tutorial. We should remove the need of a sphere object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of a tutorial that is intended to show two ways of displaying diffusion tensor ellipsoids for DTI visualization. The first is using the basic
tensor_sliceractor which allows us to slice many tensors as ellipsoids, and the second with the genericellipsoidactor I'm currently working on (#791), which can be used to display different amounts of ellipsoids. The idea is to show the use that can be made of the ellipsoid actor in the visualization of diffusion tensor ellipsoids, compared to the tensor_slicer actor, contrasting visual quality and the amount of data that can be rendered.I still working on this, it is not ready for review yet.