Repository navigation
UI: Adding getters and setters for the TextBlock2D properties - #830
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
==========================================
+ Coverage 84.30% 84.32% +0.02%
==========================================
Files 44 44
Lines 10353 10370 +17
Branches 1406 1407 +1
==========================================
+ Hits 8728 8745 +17
Misses 1255 1255
Partials 370 370
|
skoudoro
approved these changes
Aug 7, 2023
skoudoro
left a comment
Contributor
There was a problem hiding this comment.
LGTM !, thanks @ganimtron-10, merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent PR #803 added many properties to the
TextBlock2Dfor improving its functionality.This is a continuing PR which adds getter and setters for those.
Primarily focusing on
auto_font_size&dynamic_bbox.