Skip to content

UI: Adding getters and setters for the TextBlock2D properties - #830

Merged
skoudoro merged 4 commits into
fury-gl:masterfrom
ganimtron-10:textblock-attribute
Aug 7, 2023
Merged

skoudoro merged 4 commits into
fury-gl:masterfrom
ganimtron-10:textblock-attribute

Conversation

@ganimtron-10

Copy link
Copy Markdown
Contributor

Recent PR #803 added many properties to the TextBlock2D for improving its functionality.
This is a continuing PR which adds getter and setters for those.
Primarily focusing on auto_font_size & dynamic_bbox.

@codecov

codecov Bot commented Jul 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #830 (b053c88) into master (2551b7f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
+ Coverage   84.30%   84.32%   +0.02%     
==========================================
  Files          44       44              
  Lines       10353    10370      +17     
  Branches     1406     1407       +1     
==========================================
+ Hits         8728     8745      +17     
  Misses       1255     1255              
  Partials      370      370              
Files Changed Coverage Δ
fury/ui/core.py 93.43% <100.00%> (+0.21%) ⬆️

@skoudoro skoudoro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !, thanks @ganimtron-10, merging

@skoudoro
skoudoro merged commit 9a9cf7f into fury-gl:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants