Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Difference with official code - utils.MentorNet.forwawrd #1

Closed
Schmerle-Cki opened this issue Apr 30, 2022 · 1 comment
Closed

Difference with official code - utils.MentorNet.forwawrd #1

Schmerle-Cki opened this issue Apr 30, 2022 · 1 comment

Comments

@Schmerle-Cki
Copy link

Hello, thanks for your reproduction! In utils.py, line 144, upper_bound = torch.where(cur_epoch < burn_in_epoch - 1, v_zeros, v_ones).to(self.device), while in google_mentornet, codes accordingly in utils.py, line 211-212, upper_bound = tf.cond(cur_epoch < (burn_in_epoch - 1), lambda: v_ones, lambda: v_zeros). The order of v_ones and v_zeros seems to be a conflict. Is there a typo, or maybe I have misunderstood some of your definitions?

Furyton added a commit that referenced this issue Apr 30, 2022
@Furyton
Copy link
Owner

Furyton commented Apr 30, 2022

Hi, I'm afraid that is indeed a typo. I fixed it in another private repo and forgot to update it here :(
I have fixed it just now. Thank you for your reporting. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants