Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default matcher to pluginLess #1691

Merged
merged 2 commits into from Nov 26, 2019

Conversation

@Marcisbee
Copy link
Contributor

Marcisbee commented Nov 26, 2019

This PR fixes this issue: fuse-box/angular2-example#36

Problem was that LESS plugin failed if no matcher was defined (like in docs), so I guess we would create a default matcher like in SASS plugin for this to work:

pluginLess({ asText: true, useDefault: false })

Altho the workaround is to use matcher

pluginLess('*.less', { asText: true, useDefault: false })

I think this should be fixed as it was possible to define plugin without a matcher and then it's just a potato that does nothing.

@nchanged

This comment has been minimized.

Copy link
Contributor

nchanged commented Nov 26, 2019

👍 thanks a million!

@nchanged nchanged merged commit 3aa1f32 into fuse-box:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.