Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout updates #39

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@AndrewEQ
Copy link
Contributor

AndrewEQ commented Oct 30, 2019

  • made corrections to safe layout article
  • added safe layout article to main navigation
@AndrewEQ AndrewEQ requested a review from mortend Oct 30, 2019
@mortend

This comment has been minimized.

Copy link
Member

mortend commented Oct 30, 2019

https://travis-ci.com/fuse-open/docs/builds/134140187#L311

Duplicate link found in outline on line 118: layout/responsive-layout.html. Previously seen on line 12.

Hmm, it looks like generator doesn't like repeating links in outline.

outline Outdated Show resolved Hide resolved
- made corrections to safe layout article
- added safe layout article to main navigation
@AndrewEQ AndrewEQ force-pushed the rbtech:layout branch from 088fb7d to 596005c Oct 30, 2019
@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

AndrewEQ commented Oct 30, 2019

There ya go, problem solved for now but I guess its interesting to note the duplicate links issue 😄

@kusma

This comment has been minimized.

Copy link
Member

kusma commented Oct 30, 2019

Just a quick note: When it feels natural to use a bullet-list in the commit message of what the changes are, that's a reasonable indication that the bullet items should have been separate commits. That's what I would have done in this case, at least.

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

AndrewEQ commented Oct 30, 2019

Ok, will try separate them next time 👍

@ckarmy ckarmy merged commit 518bf1f into fuse-open:master Oct 30, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.