New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the ticket #1156 #1157

Merged
merged 2 commits into from May 2, 2018

Conversation

Projects
None yet
2 participants
@telatao
Copy link
Contributor

telatao commented May 2, 2018

1/ Create a script that calls this line:
Share.shareFile(image.path, "image/*", "Text To Share", ShareOrigin);
2/ Run it
=> Description is never shown, even in a simple email.

** Briefly describe changes and the motivation behind them here **

This PR contains:

  • Changelog
  • Documentation
  • Tests
Fix for the ticket #1156
1/ Create a script that calls this line:
Share.shareFile(image.path, "image/*", "Text To Share", ShareOrigin);
2/ Run it
=> Description is never shown, even in a simple email.
@kusma
Copy link
Member

kusma left a comment

Well, this is embarrassing, and should totally have been caught in code-review.

Anyway, very nice, thanks for the patch! However, there's one small detail...

@@ -151,7 +151,7 @@ namespace Fuse.Share
else if defined(iOS)
{
float2 position = float2(0);
if (args.Length > 2 && TryGetPosition(args[2], out position))
if (args.Length > 2 && TryGetPosition(args[3], out position))

This comment has been minimized.

@kusma

kusma May 2, 2018

Member

You'll need to bump the args.Length-check here also...

@kusma

kusma approved these changes May 2, 2018

Copy link
Member

kusma left a comment

Awesome, thanks!

@telatao

This comment has been minimized.

Copy link
Contributor Author

telatao commented May 2, 2018

You are Welcome!

@kusma kusma merged commit 7c81e4b into fuse-open:master May 2, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment