New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description is not managed in both NewShareFileActivity and NewShareT… #1158

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
2 participants
@telatao
Copy link
Contributor

telatao commented May 2, 2018

Description is not managed in both NewShareFileActivity and NewShareTextActivity

** Briefly describe changes and the motivation behind them here **

This PR contains:

  • Changelog
  • Documentation
  • Tests
@kusma

This comment has been minimized.

Copy link
Member

kusma commented May 4, 2018

@telatao: Would you care to explain a bit more about what this does and why?

@telatao

This comment has been minimized.

Copy link
Contributor Author

telatao commented May 7, 2018

Sure!
What this does?
ShareImage
Linking description to the given image. It works with mail, copy/past, Twitter... on FaceBook, only image will be manage, but this belongs to FaceBook, not us.

ShareText
Display the given description.

Why?
The description was not given to the SharedArray and it must be given in order to be displayed

@kusma

kusma approved these changes May 7, 2018

Copy link
Member

kusma left a comment

Ah, thanks for clarifying! I think I must have misread the code initially, this does indeed look pretty straight forward to me!

Thanks a lot!

@kusma kusma merged commit 41b09fe into fuse-open:master May 7, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment