Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Push Notification - iOS & Android Updates! (Now includes FCM - Fuse 1.10+) #1220
16 Nov - Android: Updated from GCM to FCM! :)
27 Sep - iOS & Android: Push Notification Fixes + Features
28 Sep - Added Push Notification Features
This PR contains:
ekkotech left a comment
In iOS/Impl.uno, the code will work today but will fail when the deprecated method
Also, in the completion callback, if you add a test for
hey @ekkotech, thanks for the feedback, yeah, the goal of this pr was to enhance the existing code to get it functional as it really isn't working as it stands.
iOS Issue1: I like your fallback logic, I didn't write the original but I'll enhance it with yours.
My issue with #1197 : I couldn't get it to work. I really tried, maybe there's something different between our setups, ionno, and the PR didn't seem to be moving.
So I would say the main differences are that I broke my PR's into separate bite-sized issue resolutions; for instance the map one is a critical breaking fix, so I don't see why that needs to be held up.
Ok, so the summary break down:
iOS fix - push notifications are silent right now because we don't explicitly ask for permission
Android fix - Android 8+ compatibility
@AndrewEQ re. iOS issue2: I see where you are coming from and, from a technical standpoint it has merit, but if you look at it from a data security standpoint, I have two concerns. 1) You are leaking a user's data out to APNS when the user's expectation is privacy, 2) this is library code; applications built on top of this will get a response back from APNS and go ahead and push that out to their own application server. Now there is nothing stopping the user from getting push notifications when they said they didn't want them.
@ekkotech 1) I know what you're thinking but I've tested it, the notifications are turned off for the user when they say no in the dialog. 2) It was doing this, and still is before my updates. That's where I got the initial idea from. Difference is that the current implementation is silent even when the user says "yes".
From my tests and according to the Apple docs:
Scenario 1 + 1.1 - current code
Scenario 2 + 2.1 - new code
@AndrewEQ Question for you: when you were testing your code changes, what key did you use when sending to GCM? For example, here is the script that I use for pre-API26 tests:
curl -X POST
hey @ekkotech, this was the payload structure that I was testing with: https://github.com/fuse-open/fuselibs/pull/1220/files#diff-0aae1bdd92b0184bb9df83ff47aa3973R230