Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoLocation - Added IsLocationEnabled + Permission check for StartListening(Android) #1245

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@AndrewEQ
Copy link
Contributor

AndrewEQ commented Nov 6, 2018

UX usage: GeoLocation.isLocationEnabled();

  • iOS - Added isLocationEnabled - returns boolean
  • Android - Added isLocationEnabled - returns boolean
  • Android - Added permission check and request before getting location for StartListening

This PR contains:

  • Changelog
  • Documentation
  • Tests
@AndrewEQ AndrewEQ changed the title Added IsLocationEnabled + Permission check for StartListening(Android) GeoLocation - Added IsLocationEnabled + Permission check for StartListening(Android) Nov 16, 2018
@AndrewEQ AndrewEQ requested a review from LuisRodriguezLD Apr 15, 2019
@kusma

This comment has been minimized.

Copy link
Member

kusma commented Sep 13, 2019

So, it seems nobody is willing to review this one? Sadly, this is outside of my area of expertise, but unless someone points out something wrong, I could review the "technical" parts of the code and just assume the stuff I don't know is fine so we can move forwards?

@AndrewEQ: If that's OK with you, would you mind rebasing this on master? I don't think it would be a problem, I just want to see that things still build on a newer version :)

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

AndrewEQ commented Sep 13, 2019

@kusma sure thing 👍

Copy link
Member

kusma left a comment

Looks great! Could you rebase on master and squash it all together as well?

@AndrewEQ AndrewEQ force-pushed the rbtech:Geo-Location branch from a77dfd3 to 3c795c7 Sep 17, 2019
@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

AndrewEQ commented Sep 17, 2019

Sure thing, this is improving my squashing skills 😄

…tening(Android)

UX usage: GeoLocation.isLocationEnabled();

iOS - Added isLocationEnabled - returns boolean
Android - Added isLocationEnabled - returns boolean
Android - Added permission check and request before getting location for StartListening
@AndrewEQ AndrewEQ force-pushed the rbtech:Geo-Location branch from 3c795c7 to bcb3377 Sep 17, 2019
@kusma
kusma approved these changes Sep 17, 2019
Copy link
Member

kusma left a comment

Looks good to me!

@kusma kusma merged commit a0dd478 into fuse-open:master Sep 17, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kusma

This comment has been minimized.

Copy link
Member

kusma commented Sep 17, 2019

Thanks a lot for bearing with us here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.