New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share - Android Updates #1253

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@AndrewEQ
Copy link
Contributor

AndrewEQ commented Feb 1, 2019

Updated to new android file permission requirements when sharing.
You will need to override the android_share_paths.xml(via AndroidShareImpl.uno) if you would like to add custom paths of folders you would like to give share access to.

https://medium.com/@andrewq/hello-world-eaa996c594b7

This PR contains:

  • Changelog
  • Documentation
  • Tests

AndrewEQ added some commits Feb 1, 2019

Share - Android Updates
Updated to new android file permission requirements when sharing.
You will need to override the android_share_paths.xml(via AndroidShareImpl.uno) if you would like to add custom paths of folders you would like to give share access to.
Updated with the subject extra
It adds the description to the subject of an email if sharing to email app or any app that uses  the subject field
@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

AndrewEQ commented Feb 1, 2019

Show resolved Hide resolved Source/Fuse.Share/ShareModule.uno Outdated
@kusma

This comment has been minimized.

Copy link
Member

kusma commented Feb 1, 2019

ERROR: /com: Access to the path "/com" is denied.
ERROR: /com/fuse: Access to the path "/com" is denied.
ERROR: /com/fuse/fileprovider: Access to the path "/com" is denied.

:/

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

AndrewEQ commented Feb 1, 2019

It can't create or copy the java file?

Update ShareModule.uno
removed tab
@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

AndrewEQ commented Feb 1, 2019

I just tried an uno clean, uno doctor and rebuild with an android export with my test app and can't reproduce that error.

Update AndroidShareImpl.uxl
Fixed android only condition
@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

AndrewEQ commented Feb 1, 2019

Ok, figured it out, its sorted.

@kusma kusma dismissed their stale review Feb 18, 2019

this was resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment