Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 13 DarkMode #1290

Open
wants to merge 1 commit into
base: master
from

Conversation

@AndrewEQ
Copy link
Contributor

commented Aug 31, 2019

Oh so dark and lovely 馃樃

This PR contains:

  • Changelog
  • Documentation
  • Tests

@AndrewEQ AndrewEQ requested review from ckarmy, LuisRodriguezLD and mortend Aug 31, 2019

@ichan-mb

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2019

Yey! so cool @AndrewEQ, but I think this feature should exist for Android too, so we keep cross-platform availability in Fuselibs. Refer to this for Android Q: https://developer.android.com/preview/features/darktheme#configuration_changes

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

@ichan-mb yeah, would have done it but I didn't have any device with Q to test on, do you? 馃樃

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

@mortend Travis failed cos its using an older version of XCode (9.2), I was testing on version 11 beta 6

@mortend

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@AndrewEQ Maybe we can use the preprocessor to only include iOS 13/Xcode 11 specific code when available, and fallback to printing a warning in the log or something like that when building on older versions?

Similar to what we do in https://github.com/fuse-open/fuselibs/blob/master/Source/Fuse.Platform/iOS/SystemUI.uno#L256

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

@mortend ok thanks, I'll have a look at it doing it like that

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2019

@mortend the only problem I found was trying to exclude the separate objective-c files, and so older XCode would complain about the new lines of code as the framework doesn't exist.

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

seems the only way forward, is forward lol, unless we can have an older and newer XCode check?

@kusma

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

@AndrewEQ: I don't follow... @mortend did indeed suggest to make the code XCode version dependent, and he showed an example of how to do that...

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

@kusma that code example is for code written inside uno, how do you exclude whole objective-c files? https://github.com/fuse-open/fuselibs/pull/1290/files

@mortend

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

@AndrewEQ you can also use #ifdef..#endif inside Obj-C files to exclude all or parts of the code. I can probably help if you're stuck.

@mortend

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

@AndrewEQ I don't have iOS 13 myself yet, but I think this will work: mortend@49b7887

iOS 13 DarkMode
Oh so dark and lovely 馃樃

@AndrewEQ AndrewEQ force-pushed the rbtech:iOS-DarkMode branch from 4f23882 to f156fea Sep 18, 2019

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2019

Ok updated and trying again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.