Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 13 SystemFont Changes + Previous System Font Issues #1291

Open
wants to merge 1 commit into
base: master
from

Conversation

@AndrewEQ
Copy link
Contributor

commented Aug 31, 2019

  • added iOS13 way of doing SystemFont
  • fixed older system font issues with font weight/style
  • added reasonable fallbacks for missing font weights for older system font way

This PR contains:

  • Changelog
  • Documentation
  • Tests

@AndrewEQ AndrewEQ requested review from mortend, ckarmy and LuisRodriguezLD Aug 31, 2019

@AndrewEQ AndrewEQ changed the title iOS13 SystemFont Changes + Previous System Font Issues iOS 13 SystemFont Changes + Previous System Font Issues Aug 31, 2019

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

This PR is also failing the same way as #1290, because the CI is not using latest XCode which includes iOS13 frameworks.

iOS13 SystemFont Changes + Previous System Font Issues
- added iOS13 way of doing SystemFont
- fixed older system font issues with font weight/style
- added reasonable fallbacks for missing font weights for older system font way

@AndrewEQ AndrewEQ force-pushed the rbtech:iOS-SystemFont branch from bcdf431 to 443129e Sep 18, 2019

@AndrewEQ

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2019

ok, updated with iOS 13 checks, if it passes, will probably still need someone to test on XCode version less than 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.