unoconfig: remove *Root properties (beta-3.0) - #451
Merged
Conversation
This removes IsRoot and SkipIfRoot, which had some strange effects where we've ended up patching the unoconfig-file after install, in e.g. https://github.com/fuse-open/fuse-sdk/blob/master/scripts/restore.js Let's try removing these properties for v3.0 and see if we can get rid of that unoconfig-patching.
mortend
added a commit
to mortend/uno
that referenced
this pull request
Mar 27, 2023
Same motivation as fuse-open#451, fuse-open#452 and fuse-open#453. Old names are deprecated but still work.
mortend
added a commit
to mortend/uno
that referenced
this pull request
Mar 27, 2023
Same motivation as fuse-open#451, fuse-open#452 and fuse-open#453. Old names are deprecated but still work. * Update related member names in the compiler. * Update project files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes IsRoot and SkipIfRoot, which had some strange effects where we've ended up patching the unoconfig-file after install, in e.g. https://github.com/fuse-open/fuse-sdk/blob/master/scripts/restore.js
Let's try removing these properties for v3.0 and see if we can get rid of that unoconfig-patching.