Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty effect #196

Merged
merged 37 commits into from Sep 8, 2019
Merged

Empty effect #196

merged 37 commits into from Sep 8, 2019

Conversation

robrix
Copy link
Collaborator

@robrix robrix commented Aug 25, 2019 •
edited

This PR defines an Abort effect which simply ends the current computation. It can be used for cases where you want early returns, empty without <|>, or throwError () without catchError.

I’m also considering rewriting this as a refactoring of NonDet to split its constructors into two different effect types. Edit: cf #199.

@robrix
Stub in a module for an Abort effect.
6285816
@robrix
Define an Abort effect datatype.
bfb828b
@robrix
Derive a Functor instance for Abort.
6ac6734
@robrix
Define a smart constructor for abort.
b0d3346
@robrix
📝 abort.
f4b91e4
@robrix
Re-export the standard things.
c2b1ea7
@robrix
Define an AbortC monad.
62aa664
@robrix
Derive a Generic1 instance for Abort.
62d2ac9
@robrix
Define an HFunctor instance for Abort.
312be50
@robrix
Define an Effect instance for Abort.
5dfe036
@robrix
Define a Carrier instance for AbortC.
364b572
@robrix
Define an Alternative instance for AbortC.
f4918cf
@robrix
Define a MonadFix instance for AbortC.
a18f684
@robrix
Define a MonadTrans instance for AbortC.
3e53204
@robrix
Define a MonadFail instance for AbortC.
c737897
@robrix
Define a MonadPlus instance for AbortC.
e608bac
@robrix
Define a MonadIO instance for AbortC.
3da40d1
@robrix
Set up for doctests.
7177494
@robrix
Test that aborting a computation returns Nothing.
dfd5d77
@robrix
📝 runAbort.
aa1f47e
@robrix
📝 runAbort.
5b8c118
@robrix
Re-export Abort/AbortC.
ebad101
@robrix robrix mentioned this pull request Aug 25, 2019
Merged
3 tasks
This was referenced Sep 1, 2019
Merged
Merged
Merged
@robrix robrix changed the title Abort effect Empty effect Sep 2, 2019
@robrix robrix marked this pull request as ready for review September 2, 2019 22:55
@robrix robrix requested a review from patrickt September 3, 2019 14:04
patrickt
patrickt requested changes Sep 6, 2019
View reviewed changes
src/Control/Effect/Empty.hs Show resolved Hide resolved
src/Control/Effect/Empty.hs Show resolved Hide resolved
src/Control/Effect/Empty.hs Show resolved Hide resolved
@robrix robrix requested a review from patrickt September 6, 2019 18:00
@robrix robrix merged commit 589e1ed into master Sep 8, 2019
@robrix robrix deleted the abort-effect branch September 8, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickt patrickt Awaiting requested review from patrickt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robrix @patrickt