Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse explorer UI update #2

Merged
merged 13 commits into from Feb 13, 2020
Merged

Fuse explorer UI update #2

merged 13 commits into from Feb 13, 2020

Conversation

@mul53
Copy link

mul53 commented Feb 2, 2020

Enhancements

Added ui updates

@mul53 mul53 marked this pull request as ready for review Feb 2, 2020
@mul53 mul53 requested a review from LiorRabin Feb 3, 2020
Copy link

bejavu left a comment

Please remove hard coded URLs and Address and move them to ENV params.

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 4, 2020

Moved the URL and address to environment params and modified the dockerfile to pick up the env params

@bejavu

This comment has been minimized.

Copy link

bejavu commented Feb 5, 2020

I see that this PR is referring to the old design.
Please see the new design:
https://explorer.bounties.network/bounty/3788
https://i.imgur.com/W4P8tMz.jpg

Copy link

bejavu left a comment

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 5, 2020

@bejavu i made changes to the ui here is a preview, i have a question regarding the circle-progress element its derived from which data?

Screenshot from 2020-02-05 17-38-44

@bejavu

This comment has been minimized.

Copy link

bejavu commented Feb 5, 2020

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 5, 2020

@LiorRabin I have fixed the typo, @bejavu are the UI changes heading in the right direction?

@LiorRabin

This comment has been minimized.

Copy link
Member

LiorRabin commented Feb 6, 2020

Hi @mul53, the wallet addresses icon is different, and the circle-progress is still missing, but other then that seems to be fine.

@LiorRabin

This comment has been minimized.

Copy link
Member

LiorRabin commented Feb 6, 2020

@Gilat-R

This comment has been minimized.

Copy link

Gilat-R commented Feb 6, 2020

Hi @mul53
Some design QA notes:

  1. SVG icons attached. please replace them instead of what you used.
  2. The changing values size needs to be bigger like in the original design and their color needs to be: #8291A0
  3. Current cycle blocks value size needs to be smaller like in the original design
  4. Around the Tabs, there is an outer glow effect. please remove it

icon.zip

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 6, 2020

@LiorRabin @Gilat-R I have made changes, with the progress circle which direction should it move towards?

@Gilat-R

This comment has been minimized.

Copy link

Gilat-R commented Feb 6, 2020

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 10, 2020

Any feedback?

@LiorRabin LiorRabin requested a review from Gilat-R Feb 10, 2020
@LiorRabin LiorRabin requested a review from bejavu Feb 10, 2020
@LiorRabin

This comment has been minimized.

Copy link
Member

LiorRabin commented Feb 10, 2020

@mul53 sorry for the confusion, the full circle time needs to be an ENV variable as well because for our testnet it's 1 hour and for mainnet 24 hours.
So here it's currently wrong https://explorer-testnet.fuse.io/

Copy link
Member

LiorRabin left a comment

see my comment about the full circle

@LiorRabin

This comment has been minimized.

Copy link
Member

LiorRabin commented Feb 10, 2020

@mul53 what is cycleIntervalInSeconds? It is the total cycle length?

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 10, 2020

yes its the total cycle length in seconds

@LiorRabin

This comment has been minimized.

Copy link
Member

LiorRabin commented Feb 10, 2020

So total time in seconds is (cycleEndBlock-cycleStartBlock) * 5 always, no matter which environment. And time passed since cycle started is (currentBlock-cycleStartBlock) * 5.
That way there's no need for another ENV variable

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 10, 2020

@LiorRabin cool, let me do that

@bejavu

This comment has been minimized.

Copy link

bejavu commented Feb 10, 2020

And one small thing,
There should be a "show all" link (in the design) in the validators card.
it should be linked to: https://health-testnet.fuse.io (env param)

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 10, 2020

@bejavu @LiorRabin any suggestions for the name(env param)?

@LiorRabin

This comment has been minimized.

Copy link
Member

LiorRabin commented Feb 10, 2020

@mul53 VALIDATORS_INFO_URL or something like that

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 10, 2020

@LiorRabin does cycleEndInBlocks * 5 return seconds in multiples of five?

@LiorRabin

This comment has been minimized.

Copy link
Member

LiorRabin commented Feb 10, 2020

@mul53 sorry, didn't understand the question.

For example:
cycle start block = 100
cycle end block = 200
each block time is 5 seconds
cycle duration in seconds is (200-100)*5 = 500 seconds

Does this help?

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 10, 2020

Also, lets do the tick time 1 sec and not each block (5 second).

@LiorRabin i want to achieve this, is it possible when deriving the value from this cycleEndInBlocks * 5 its fine found an easier way

@LiorRabin LiorRabin self-assigned this Feb 10, 2020
@bejavu bejavu dismissed stale reviews from Gilat-R and themself Feb 11, 2020

no

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 12, 2020

@LiorRabin @bejavu added the changes above

@LiorRabin LiorRabin self-requested a review Feb 12, 2020
@Gilat-R

This comment has been minimized.

Copy link

Gilat-R commented Feb 12, 2020

Hi!
It looks great!
Just one more thing...
Align the Current cycle blocks value to the Active validators & Wallet addresses
values.
See the attached image that explains.
Screen Shot 2020-02-12 at 12 33 57

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 12, 2020

@Gilat-R i added the styles to align the values, now looks better

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 12, 2020

@Gilat-R on mobile, should the font sizes be reduced?

@Gilat-R

This comment has been minimized.

Copy link

Gilat-R commented Feb 12, 2020

@Gilat-R on mobile, should the font sizes be reduced?
No changes needed on the mobile.
Thx

@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 13, 2020

@Gilat-R cool, so everything is okay?

@bejavu

This comment has been minimized.

Copy link

bejavu commented Feb 13, 2020

@mul53 yes, everything is ok, we will merge and deploy it to the prod env soon (explorer.fuse.io)
please make a submission in the bounty network (https://explorer.bounties.network/bounty/3788) so we can reward you with your bounty.

Thanks!

@bejavu bejavu merged commit 44326ed into fuseio:master Feb 13, 2020
@mul53

This comment has been minimized.

Copy link
Author

mul53 commented Feb 13, 2020

@bejavu thanks, i have made a submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.