Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix issue where bitModel could not be retrieved on GraalVM #61
Conversation
Non-standard system properties `sun.arch.data.model` and `com.ibm.vm.bitmode` are not available in Substrate VM (GraalVM native images). Without this fix, the `extractAndLoad` method never succeeds, even if the native library is available as a resource in the GraalVM native image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
remkop commentedOct 23, 2019
This PR fixes an issue in the
Library.getBitModel()method when running in a GraalVM native image.Non-standard system properties
sun.arch.data.modelandcom.ibm.vm.bitmodeare not available in Substrate VM (GraalVM native images). Without this fix, theLibrary.getBitModel()method always returns-1, and theextractAndLoadmethod never succeeds, even if the native library is available as a resource in the GraalVM native image.This PR partly addresses fusesource/jansi#162 ; the other part is addressed by fusesource/jansi-native#21 .