Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoloidalFieldCoilSet ignores azimuth_placement_angle #130

Open
RemDelaporteMathurin opened this issue Nov 19, 2021 · 1 comment
Open

PoloidalFieldCoilSet ignores azimuth_placement_angle #130

RemDelaporteMathurin opened this issue Nov 19, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@RemDelaporteMathurin
Copy link
Member

Because PoloidalFieldCoilSet overwrites create_solid, the step rotate_solid is ignored.

Hence, the azimuth_placement_angle has no influence on this shape.

def create_solid(self):
"""Creates a 3d solid using points with straight connections
edges, azimuth_placement_angle and rotation angle.
individual solids in the compound can be accessed using .Solids()[i]
where i is an int
Returns:
A CadQuery solid: A 3D solid volume
"""
iter_points = iter(self.points)
pf_coils_set = []
wires = []
for p1, p2, p3, p4 in zip(
iter_points, iter_points, iter_points, iter_points):
solid = (
cq.Workplane(self.workplane)
.polyline([p1[:2], p2[:2], p3[:2], p4[:2]])
)
wire = solid.close()
wires.append(wire)
solid = wire.revolve(self.rotation_angle)
pf_coils_set.append(solid)
compound = cq.Compound.makeCompound(
[a.val() for a in pf_coils_set]
)
self.wire = wires
self.solid = compound
return compound

@RemDelaporteMathurin RemDelaporteMathurin added the bug Something isn't working label Nov 19, 2021
@RemDelaporteMathurin
Copy link
Member Author

Similarly, all the boolean operations are ignored (cut, union,...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant