[feature] [SUPPORT-2357] upgrade angular version from v14 to v17. #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* used angular official documentation for upgrading the version (ng update) * replaced ng2-codemirror with ngx-codemirror (both of these are base on codemirror) for code-snippets as ng2-codemirror is no longer workin in Angular-v16 and above * updated rollup config file(used in the build script), as the docs and config has changed * changed fusionchart.component input prop from string to any as it also accects an object
|
Looks good to me. |
kruzznikam
added a commit
that referenced
this pull request
May 6, 2024
…fusioncharts example, bumped integration version feature/support-2357 upgraded angular version from v14 to v17. (#186) * used angular official documentation for upgrading the version (ng update) * replaced ng2-codemirror with ngx-codemirror (both of these are base on codemirror) for code-snippets as ng2-codemirror is no longer workin in Angular-v16 and above * updated rollup config file(used in the build script), as the docs and config has changed * changed fusionchart.component input prop from string to any as it also accects an object [feature] [support - 2357] create a new angular fusioncharts example (#188) -> Create a new examples folder which has a new angularv17 project and shows how to use angular-fusioncharts library bumped integration version from 4.0.3 to 4.1.0 * removed unnessary code from app.component.ts
meherhowji
added a commit
that referenced
this pull request
Jun 4, 2024
[feature] [SUPPORT-2357] upgrade angular version from v14 to v17. (#186)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
angularfrom 14.x to 17.3.6used angular official documentation for upgrading the version (ng update)
Changelogs
Sourced from angular's changelog.
File Changes
Replaces
ng2-codemirrorfrom withngx-codemirrorng2-codemirror is no longer working in Angular-v16 and above and is not maintained from last 7 years.
ngx-codemirror v7 is open source with MIT license. It uses the same peer dependency codemirror, as ng2-codemirror does.
File Changes
Other File Changes
Changed the type of input prop 'chartConfig' to same as 'dataSource' as it can also accept string and object.
Updated rollup config file(used in the build script), as the docs and config has changed.
Fixed compilation errors.
Made a new build using 'angular run build' command.