From 05f4c46078af895301de0c2b0f14676f64f5e42a Mon Sep 17 00:00:00 2001 From: Guillaume Rousse Date: Sat, 18 Jun 2011 15:18:36 +0200 Subject: [PATCH] simplification --- lib/FusionInventory/Agent/Task/NetDiscovery.pm | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/lib/FusionInventory/Agent/Task/NetDiscovery.pm b/lib/FusionInventory/Agent/Task/NetDiscovery.pm index d42d39fb57..f94bf212b6 100644 --- a/lib/FusionInventory/Agent/Task/NetDiscovery.pm +++ b/lib/FusionInventory/Agent/Task/NetDiscovery.pm @@ -651,16 +651,10 @@ sub _discoverBySNMP { my ($self, $device, $ip, $credentials, $dico, $entity) = @_; $self->{logger}->debug("[ip] : SNMP discovery"); - my $i = "4"; - my $snmpv; - while ($i != 1) { - $i--; - $snmpv = $i; - if ($i == 2) { - $snmpv = "2c"; - } + + foreach my $version (qw(3 2c 1)) { foreach my $credential (@{$credentials}) { - next unless $credential->{VERSION} eq $snmpv; + next unless $credential->{VERSION} eq $version; my $session = FusionInventory::Agent::SNMP->new( version => $credential->{VERSION},