Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform fusioninventory group label in task job #2316

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
3 participants
@ddurieux
Copy link
Member

ddurieux commented Oct 19, 2017

No description provided.

@@ -157,7 +157,7 @@ static function getModulesMethods() {
static function task_definitiontype_wakeonlan($a_itemtype) {
$a_itemtype['Computer'] = Computer::getTypeName();
$a_itemtype['PluginFusioninventoryDeployGroup'] = __('Dynamic Group');
$a_itemtype['PluginFusioninventoryDeployGroup'] = __('Fusioninventory group');

This comment has been minimized.

@orthagh

orthagh Oct 24, 2017

Contributor

'Fusioninventory group' is not in GLPI locales context, so you should add , 'fusioninventory'

This comment has been minimized.

@wawax

wawax Nov 27, 2017

Member

hi @ddurieux ! can you perform the requested change ? thanks

This comment has been minimized.

@wawax

wawax Dec 5, 2017

Member

I suggest to modify the locale in DeployGroup::getTypeName and use this method instead of calling directly gettext

@@ -157,7 +157,7 @@ static function getModulesMethods() {
static function task_definitiontype_wakeonlan($a_itemtype) {
$a_itemtype['Computer'] = Computer::getTypeName();
$a_itemtype['PluginFusioninventoryDeployGroup'] = __('Dynamic Group');
$a_itemtype['PluginFusioninventoryDeployGroup'] = __('Fusioninventory group');

This comment has been minimized.

@wawax

wawax Dec 5, 2017

Member

I suggest to modify the locale in DeployGroup::getTypeName and use this method instead of calling directly gettext

@wawax wawax force-pushed the master+uniform_dynamic_group_name branch from 9ee896e to f832a08 Dec 6, 2017

@wawax wawax changed the title Uniform fusioninvntory group label in task job Uniform fusioninventory group label in task job Dec 6, 2017

@wawax

wawax approved these changes Dec 6, 2017

@wawax wawax merged commit 7b3d2a7 into master Dec 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ddurieux ddurieux added this to the 9.2+2.0 milestone May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.