New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warning in timeslot form #2318

Merged
merged 1 commit into from Oct 20, 2017

Conversation

Projects
None yet
3 participants
@orthagh
Contributor

orthagh commented Oct 20, 2017

when displaying a timeslot form:

2017-10-20 09:37:43 [2@LU002]
  *** MySQL query error:
  SQL: SELECT * FROM `glpi_plugin_fusioninventory_timeslotentries` WHERE `plugin_fusioninventory_timeslots_id`=\'1\' ORDER BY `day`,
  Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 1
  Backtrace :
  inc/dbmysqliterator.class.php:264                  
  inc/dbmysql.class.php:540                          DBmysqlIterator->__construct()
  inc/dbutils.class.php:441                          DBmysql->request()
  inc/db.function.php:270                            DbUtils->getAllDataFromTable()
  ...fusioninventory/inc/timeslotentry.class.php:194 getAllDatasFromTable()
  ...fusioninventory/inc/timeslotentry.class.php:173 PluginFusioninventoryTimeslotEntry->formDeleteEntry()
  plugins/fusioninventory/inc/timeslot.class.php:281 PluginFusioninventoryTimeslotEntry->formEntry()
  inc/commonglpi.class.php:472                       PluginFusioninventoryTimeslot->showForm()
  ajax/common.tabs.php:96                            CommonGLPI::displayStandardTab()

@orthagh orthagh added the bug label Oct 20, 2017

@orthagh orthagh requested review from trasher and ddurieux Oct 20, 2017

@trasher

Event if tis fix is OK (it switches to the new way); it should not have been broken...
There is aparently an issue on the dbiterator

@orthagh orthagh merged commit c11ffee into fusioninventory:glpi9.2 Oct 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

orthagh added a commit that referenced this pull request Oct 20, 2017

@ddurieux ddurieux added this to the 9.2+2.0 milestone May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment