New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge agent on computer purge when no task associated #2323

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
3 participants
@orthagh
Contributor

orthagh commented Oct 23, 2017

Following the irc discussion

@orthagh orthagh requested review from trasher and ddurieux Oct 23, 2017

@trasher

This comment has been minimized.

Collaborator

trasher commented Oct 24, 2017

Tests are failing ;)

@orthagh orthagh merged commit 6d89acf into fusioninventory:glpi9.2 Oct 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ddurieux

This comment has been minimized.

Member

ddurieux commented Oct 24, 2017

I'm not agree, delete the taskjobstates based on agents_id can be very long and it's not a good idea to make it here. Perhaps add a cron task to clean this the night

@orthagh

This comment has been minimized.

Contributor

orthagh commented Oct 25, 2017

we don't delete taskjobstates, we delete agent if no taskjobstates exist for it

@ddurieux

This comment has been minimized.

Member

ddurieux commented Oct 25, 2017

Ok, you're right, but use limit 1 in $states = $pfTaskjobstate->find(... it will prevent get all lines when have very too many ;)

@orthagh

This comment has been minimized.

Contributor

orthagh commented Oct 25, 2017

ok, good point, i push a pr this morning for that

orthagh added a commit to orthagh/fusioninventory-for-glpi that referenced this pull request Oct 25, 2017

ddurieux added a commit that referenced this pull request Oct 25, 2017

Merge pull request #2325 from orthagh/follow_2323
limit selection of states when deleting agent, follow #2323

@ddurieux ddurieux added this to the 9.2+2.0 milestone May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment