New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove agent tab in computer, and get agent status in auto_inventory block #2372

Merged
merged 1 commit into from Dec 5, 2017

Conversation

Projects
None yet
4 participants
@orthagh
Contributor

orthagh commented Dec 4, 2017

Status is called by ajax, so the computer page can't stuck.
I change showInfoForComputer prototype to pass Computer object needed by showRemoteStatus method

screenshot:
image

@orthagh orthagh requested review from trasher, ddurieux and wawax Dec 4, 2017

@ddurieux

No i'm not agree, because each time you display the main form the computer it will try connect to the agent and if not (timeout) the page will not display before this timeout.
That's why we keep this in a separate tab

@trasher

This comment has been minimized.

Collaborator

trasher commented Dec 5, 2017

The URL call that previously blocks the page is now called from ajax, this should no longer blocks page load.

@orthagh

This comment has been minimized.

Contributor

orthagh commented Dec 5, 2017

Hello @ddurieux, like @trasher said, we manage the blocking request by calling it in ajax (after dom ready)
So on page display (or reload), we don't stuck waiting for answer

case 'noanswer':
$agentStatus['message'] = "<i class='fa fa-exclamation'></i>".
__('Impossible to communicate with agent!', 'fusioninventory');

This comment has been minimized.

@wawax

wawax Dec 5, 2017

Member

I would suggest to change the locale to "Impossible to reach the agent" or "Cannot contact the agent"

@orthagh

This comment has been minimized.

Contributor

orthagh commented Dec 5, 2017

@ddurieux, i did better.

The status is still in main form, but not auto triggered, it now need a click to send the first request, see:

  • status ko:
    peek 05-12-2017 11-21

  • status ok:
    peek 05-12-2017 11-23

@ddurieux

This comment has been minimized.

Member

ddurieux commented Dec 5, 2017

Ok for me ;)

remove agent tab in computer, and get agent status in auto_inventory …
…block

animate get status

add header connection close

don't trigger auto

add sentence when no request

fix locale

all ajax and autorefresh after forceinventory
@wawax

wawax approved these changes Dec 5, 2017

@orthagh orthagh merged commit 5692ae8 into fusioninventory:glpi9.2 Dec 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

orthagh added a commit that referenced this pull request Dec 5, 2017

remove agent tab in computer, and get agent status in auto_inventory …
…block (#2372)

animate get status

add header connection close

don't trigger auto

add sentence when no request

fix locale

all ajax and autorefresh after forceinventory

@wawax wawax added the improvement label Jan 29, 2018

@wawax wawax added this to the 9.2+2.0 milestone Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment