New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fields plugin in the search engine of computers groups #2418

Merged
merged 7 commits into from Jan 30, 2018

Conversation

Projects
None yet
3 participants
@mohierf
Collaborator

mohierf commented Jan 5, 2018

This allow to use the Fields plugin defined fields in the search criteria of the static or dynamic computers groups. Same for the computer information collected in registry or WMI ...

Note that this PR is based on the add-itesm-count branch (the 4 first commits) because it will be easier to merge once #2397 is merged 馃槈 You may even merge this PR and forget the other one.

@mohierf

This comment has been minimized.

Collaborator

mohierf commented Jan 11, 2018

@wawax : would you mind I squash the commits? My idea is to have only 2/3 commits in this PR...

@@ -154,13 +241,18 @@ static function showList($itemtype, $params, $forcedisplay) {
$_GET['_in_modal'] = true;

This comment has been minimized.

@wawax

wawax Jan 29, 2018

Member

it doesn't seems to be a good idea to set the variable to true because the GLPI header is lost when browsing search results

This comment has been minimized.

@mohierf

mohierf Jan 29, 2018

Collaborator

Ok. You are right ! It is obviously a bad idea! I do not even understand how this should run correctly on my test instance 馃槥

@wawax

wawax approved these changes Jan 30, 2018

@wawax wawax merged commit 5491ac1 into fusioninventory:glpi9.2 Jan 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wawax pushed a commit that referenced this pull request Feb 1, 2018

Use fields plugin in the search engine of computers groups (#2418)
* Dynamic computers groups - add the matching items on the items tab

* Restore the broken pagination in the dynamic group
Add a preview in the search form of the dynamic groups

* Remove unused showGenericSearch function

* Allow to include Fields plugin fields in the computers groups criteria

* Allow to use collected (registry,wmi,...) information in the groups criteria

* Do not display search result for a dynamic group on the search tab

* Fix modal view for the dynamic group search results

@mohierf mohierf deleted the mohierf:use-fields-plugin branch Feb 8, 2018

@ddurieux ddurieux added this to the 9.2+2.0 milestone May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment