New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add entries in the log at asset creation #2462

Merged
merged 3 commits into from Feb 1, 2018

Conversation

Projects
None yet
2 participants
@wawax
Member

wawax commented Jan 31, 2018

Harmonize log behavior at asset creation based on what's done for computers :

  • do not add a log entry during OS creation for a computer
  • do not add log entries when manually inserting a XML of SNMP inventory for printers & network devices

@wawax wawax added the bug label Jan 31, 2018

@wawax wawax added this to the 9.2+2.0 milestone Jan 31, 2018

@wawax wawax self-assigned this Jan 31, 2018

@wawax wawax requested review from trasher and ddurieux Jan 31, 2018

'FROM' => getTableForItemType("PluginFusioninventoryNetworkEquipment"),
'WHERE' => ['networkequipments_id' => $items_id]
];
foreach ($DB->request($params) as $data) {

This comment has been minimized.

@trasher

trasher Jan 31, 2018

Collaborator

Maybe avoid calling a method in the loop. I'm not sure a foreach is OK here; you should have used somtehing like while ($data = $iterator->next())

'FROM' => getTableForItemType("PluginFusioninventoryPrinter"),
'WHERE' => ['printers_id' => $printers_id]
];
foreach ($DB->request($params) as $data) {

This comment has been minimized.

@trasher

trasher Jan 31, 2018

Collaborator

Same here

@trasher

trasher approved these changes Feb 1, 2018

LGTM

@wawax wawax merged commit c25eb9c into fusioninventory:glpi9.2 Feb 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wawax wawax deleted the TECLIB:fix_firwmare_simcard_history branch Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment