Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge logic from fusion-apollo-universal-client, export multiple plugins #177

Merged
merged 2 commits into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@ganemone
Copy link
Contributor

commented Apr 8, 2019

This updates the API to include the logic from fusion-apollo-universal-client and to use a render enhancer pattern.

@ganemone ganemone added the feature label Apr 8, 2019

@KevinGrandon
Copy link
Contributor

left a comment

Looks good, nice work!

@@ -0,0 +1,27 @@
/** Copyright (c) 2018 Uber Technologies, Inc.

This comment has been minimized.

Copy link
@KevinGrandon

KevinGrandon Apr 9, 2019

Contributor

dat year though 😮😅
(I'm kidding, but I'm sure this is going to be fun to fix in all of our files)

@ganemone

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

!merge

@fusion-bot fusion-bot bot merged commit 4897aeb into fusionjs:master Apr 9, 2019

20 checks passed

buildkite/fusion-plugin-apollo Build #934 passed (2 minutes, 2 seconds)
Details
buildkite/fusion-plugin-apollo/chrome-white-check-mark Passed (41 seconds)
Details
buildkite/fusion-plugin-apollo/chrome-white-check-mark-node8 Passed (26 seconds)
Details
buildkite/fusion-plugin-apollo/docker-package Passed (1 minute)
Details
buildkite/fusion-plugin-apollo/docker-package-node8 Passed (1 minute, 4 seconds)
Details
buildkite/fusion-plugin-apollo/eslint Passed (25 seconds)
Details
buildkite/fusion-plugin-apollo/eslint-node8 Passed (24 seconds)
Details
buildkite/fusion-plugin-apollo/flowtype Passed (42 seconds)
Details
buildkite/fusion-plugin-apollo/flowtype-node8 Passed (44 seconds)
Details
buildkite/fusion-plugin-apollo/node-white-check-mark Passed (25 seconds)
Details
buildkite/fusion-plugin-apollo/node-white-check-mark-node8 Passed (25 seconds)
Details
buildkite/fusion-plugin-apollo/pipeline Passed (7 seconds)
Details
ci-gate Pull Request accepted for CI
license/cla Contributor License Agreement is signed.
Details
probot/label-docs-pr Docs label has been set (or unset)
probot/migrations Migration guide provided
probot/pr-label At least one required semver-related label exists
probot/pr-title PR title is valid
probot/release-verification Verification not required for this PR.
probot/todos All TODOs have open issues
@fusion-bot

This comment has been minimized.

Copy link

commented Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.