Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow to 0.96 and fix flow error #179

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@KevinGrandon
Copy link
Contributor

KevinGrandon commented Apr 9, 2019

The upgrade resulted in an error like:

image

Casting to a string seems to fix it.

Fixes #163

@@ -100,7 +100,7 @@ export default (renderFn: Render) =>
const serialized = JSON.stringify(initialState);
const script = html`
<script type="application/json" id="__APOLLO_STATE__">
${serialized}
${String(serialized)}

This comment has been minimized.

Copy link
@KevinGrandon

KevinGrandon Apr 9, 2019

Author Contributor

Hmm, or is this going to cause issues with the html tagged template functionality? 🤔

This comment has been minimized.

Copy link
@KevinGrandon

KevinGrandon Apr 9, 2019

Author Contributor

No, I guess serialized should be a string after all given the JSON.stringify call above.

@KevinGrandon

This comment has been minimized.

Copy link
Contributor Author

KevinGrandon commented Apr 10, 2019

!merge

@fusion-bot fusion-bot bot merged commit dea4d0d into master Apr 10, 2019

22 checks passed

buildkite/fusion-plugin-apollo Build #936 passed (2 minutes, 31 seconds)
Details
buildkite/fusion-plugin-apollo/chrome-white-check-mark Passed (38 seconds)
Details
buildkite/fusion-plugin-apollo/chrome-white-check-mark-node8 Passed (40 seconds)
Details
buildkite/fusion-plugin-apollo/docker-package Passed (1 minute, 23 seconds)
Details
buildkite/fusion-plugin-apollo/docker-package-node8 Passed (1 minute, 22 seconds)
Details
buildkite/fusion-plugin-apollo/eslint Passed (40 seconds)
Details
buildkite/fusion-plugin-apollo/eslint-node8 Passed (39 seconds)
Details
buildkite/fusion-plugin-apollo/flowtype Passed (25 seconds)
Details
buildkite/fusion-plugin-apollo/flowtype-node8 Passed (44 seconds)
Details
buildkite/fusion-plugin-apollo/node-white-check-mark Passed (41 seconds)
Details
buildkite/fusion-plugin-apollo/node-white-check-mark-node8 Passed (39 seconds)
Details
buildkite/fusion-plugin-apollo/pipeline Passed (10 seconds)
Details
ci-gate Pull Request accepted for CI
license/cla Contributor License Agreement is signed.
Details
probot/label-docs-pr Docs label has been set (or unset)
probot/label-release-pr Release label has been set (or unset)
probot/migrations Migration guide provided
probot/pr-label At least one required semver-related label exists
probot/pr-license Repo has a LICENSE file
probot/pr-title PR title is valid
probot/release-verification Verification not required for this pull request.
probot/todos All TODOs have open issues

@fusion-bot fusion-bot bot deleted the update-flow-0-96 branch Apr 10, 2019

@fusion-bot

This comment has been minimized.

Copy link

fusion-bot bot commented Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.