Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialization of state on server side render #181

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@szymn
Copy link
Contributor

commented Apr 10, 2019

Serialization of state doesn't work after update to version 2.0 as middleware is not waiting for virtual dom rendering before adding the state to the response body.

@KevinGrandon
Copy link
Contributor

left a comment

Thank you very much for the pull request. It would be amazing if we could add a test for this. Any chance that’s something you’d like to work on?

@szymn

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

Yeah, I can add it. I will probably do that on Monday/Tuesday, I don't have time to do that until end of this week.

@szymn

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

I see this was fixed in #183, so closing this one.

@szymn szymn closed this Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.