Skip to content
This repository has been archived by the owner. It is now read-only.

Fix cases for font-face styles #154

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
5 participants
@angus-c
Copy link
Contributor

commented May 1, 2019

No description provided.

@angus-c angus-c requested review from KevinGrandon and AlexMSmithCA May 1, 2019

@angus-c angus-c added bugfix ci labels May 1, 2019

@UberOpenSourceBot UberOpenSourceBot removed the ci label May 1, 2019

@angus-c angus-c requested review from chrisdothtml, ganemone, lhorie and rtsao May 1, 2019

@codecov

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@5055e25). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #154   +/-   ##
=========================================
  Coverage          ?   52.63%           
=========================================
  Files             ?        9           
  Lines             ?      152           
  Branches          ?       31           
=========================================
  Hits              ?       80           
  Misses            ?       72           
  Partials          ?        0
Impacted Files Coverage Δ
src/generate-font-faces.js 95% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5055e25...72899fb. Read the comment docs.

@angus-c angus-c requested a review from derekjuber May 1, 2019

@derekjuber

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

What happened with the lock file that stripped the integrity fields?

@angus-c

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

What happened with the lock file that stripped the integrity fields?

I don't know. This seems to happen randomly. Do you know what purpose the integrity fields serve?

@chrisdothtml

This comment has been minimized.

Copy link
Member

commented May 1, 2019

See yarnpkg/yarn#6440 for info about the integrity lines

@angus-c

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

See yarnpkg/yarn#6440 for info about the integrity lines

Much clearer now 😱

@angus-c angus-c merged commit 90e2dcc into master May 2, 2019

24 checks passed

buildkite/fusion-plugin-font-loader-react Build #269 passed (2 minutes, 21 seconds)
Details
buildkite/fusion-plugin-font-loader-react/chrome-white-check-mark Passed (26 seconds)
Details
buildkite/fusion-plugin-font-loader-react/chrome-white-check-mark-node8 Passed (27 seconds)
Details
buildkite/fusion-plugin-font-loader-react/docker-package Passed (1 minute, 22 seconds)
Details
buildkite/fusion-plugin-font-loader-react/docker-package-node8 Passed (1 minute, 1 second)
Details
buildkite/fusion-plugin-font-loader-react/eslint Passed (40 seconds)
Details
buildkite/fusion-plugin-font-loader-react/eslint-node8 Passed (22 seconds)
Details
buildkite/fusion-plugin-font-loader-react/flowtype Passed (23 seconds)
Details
buildkite/fusion-plugin-font-loader-react/flowtype-node8 Passed (22 seconds)
Details
buildkite/fusion-plugin-font-loader-react/node-white-check-mark Passed (23 seconds)
Details
buildkite/fusion-plugin-font-loader-react/node-white-check-mark-node8 Passed (41 seconds)
Details
buildkite/fusion-plugin-font-loader-react/pipeline Passed (8 seconds)
Details
ci-gate Pull Request accepted for CI
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
license/cla Contributor License Agreement is signed.
Details
probot/label-docs-pr Docs label has been set (or unset)
probot/label-release-pr Release label has been set (or unset)
probot/migrations Migration guide provided
probot/pr-label At least one required semver-related label exists
probot/pr-license Repo has a LICENSE file
probot/pr-title PR title is valid
probot/release-verification Verification not required for this pull request.
probot/todos All TODOs have open issues

@fusionjs-bot fusionjs-bot bot deleted the fix-style-case branch May 2, 2019

@fusionjs-bot

This comment has been minimized.

Copy link

commented May 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.