Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export HelmetProvider along with Helmet + Plugin #98

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@koulmomo
Copy link
Contributor

commented Apr 11, 2019

In certain scenarios (such as unit testing), you might want to be able
to use a <HelmetProvider /> without needing to set up a full fledged
fusion app instance and using the plugin.

In these cases, you currently need to add react-helmet-async as a
dep/devDep and make sure the version is not different from the one in
fusion-plugin-react-helmet-async.

feature: export HelmetProvider along with Helmet + Plugin
In certain scenarios (such as unit testing), you might want to be able
to use a `<HelmetProvider />` without needing to set up a full fledged
fusion app instance and using the plugin.

In these cases, you currently need to add `react-helmet-async` as a
`dep/devDep` and make sure the version is not different from the one in
`fusion-plugin-react-helmet-async`.

@koulmomo koulmomo changed the title feature: export HelmetProvider along with Helmet + Plugin Feature: export HelmetProvider along with Helmet + Plugin Apr 11, 2019

@UberOpenSourceBot UberOpenSourceBot removed the ci label Apr 12, 2019

@KevinGrandon
Copy link
Contributor

left a comment

I think this seems reasonable to me if it helps with testing. Might be worth updating the API docs in the README, maybe.

@KevinGrandon KevinGrandon changed the title Feature: export HelmetProvider along with Helmet + Plugin Export HelmetProvider along with Helmet + Plugin Apr 12, 2019

@KevinGrandon

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

!merge

@fusion-bot fusion-bot bot merged commit a1357df into fusionjs:master Apr 12, 2019

22 checks passed

buildkite/fusion-plugin-react-helmet-async Build #205 passed (2 minutes, 51 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/chrome-white-check-mark Passed (40 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/chrome-white-check-mark-node8 Passed (42 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/docker-package Passed (1 minute, 12 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/docker-package-node8 Passed (53 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/eslint Passed (38 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/eslint-node8 Passed (39 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/flowtype Passed (41 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/flowtype-node8 Passed (40 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/node-white-check-mark Passed (40 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/node-white-check-mark-node8 Passed (40 seconds)
Details
buildkite/fusion-plugin-react-helmet-async/pipeline Passed (8 seconds)
Details
ci-gate Pull Request accepted for CI
license/cla Contributor License Agreement is signed.
Details
probot/label-docs-pr Docs label has been set (or unset)
probot/label-release-pr Release label has been set (or unset)
probot/migrations Migration guide provided
probot/pr-label At least one required semver-related label exists
probot/pr-license Repo has a LICENSE file
probot/pr-title PR title is valid
probot/release-verification Verification not required for this PR.
probot/todos All TODOs have open issues
@fusion-bot

This comment has been minimized.

Copy link

commented Apr 12, 2019

@koulmomo koulmomo deleted the koulmomo:chore/export-helmet-provider branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.