Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace to Redux Devtools Extension #200

Merged
merged 6 commits into from Apr 19, 2019

Conversation

Projects
None yet
7 participants
@CLAassistant

This comment has been minimized.

Copy link

commented Apr 10, 2019

CLA assistant check
All committers have signed the CLA.

@KevinGrandon
Copy link
Contributor

left a comment

Thanks for the PR! Looks good to me, but we should remove the package-lock.json file since we use yarn for fusion development. Happy to send a contribution to your branch if helpful.

@codecov

This comment has been minimized.

Copy link

commented Apr 10, 2019

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files           5        5           
  Lines          62       62           
  Branches       12       12           
=======================================
  Hits           61       61           
  Partials        1        1
Impacted Files Coverage Δ
src/browser.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875c1dc...b68806c. Read the comment docs.

@codalife

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

Thanks for the PR! Looks good to me, but we should remove the package-lock.json file since we use yarn for fusion development. Happy to send a contribution to your branch if helpful.

Removed lock. Rookie mistake

Show resolved Hide resolved package.json Outdated

@chrisdothtml chrisdothtml added the ci label Apr 10, 2019

@UberOpenSourceBot UberOpenSourceBot removed the ci label Apr 10, 2019

@mlmorg

This comment has been minimized.

Copy link

commented Apr 12, 2019

We still want the package.json, you just don't need to bump the version since it will be handled by our release process.

@ganemone ganemone added the ci label Apr 16, 2019

@UberOpenSourceBot UberOpenSourceBot removed the ci label Apr 16, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 19, 2019

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files           5        5           
  Lines          62       62           
  Branches       12       12           
=======================================
  Hits           61       61           
  Partials        1        1
Impacted Files Coverage Δ
src/browser.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875c1dc...b68806c. Read the comment docs.

@KevinGrandon

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

!merge

@fusionjs-bot fusionjs-bot bot merged commit 8e41b4a into fusionjs:master Apr 19, 2019

22 checks passed

buildkite/fusion-plugin-react-redux Build #434 passed (2 minutes, 14 seconds)
Details
buildkite/fusion-plugin-react-redux/chrome-white-check-mark Passed (27 seconds)
Details
buildkite/fusion-plugin-react-redux/chrome-white-check-mark-node8 Passed (24 seconds)
Details
buildkite/fusion-plugin-react-redux/docker-package Passed (57 seconds)
Details
buildkite/fusion-plugin-react-redux/docker-package-node8 Passed (1 minute, 16 seconds)
Details
buildkite/fusion-plugin-react-redux/eslint Passed (40 seconds)
Details
buildkite/fusion-plugin-react-redux/eslint-node8 Passed (40 seconds)
Details
buildkite/fusion-plugin-react-redux/flowtype Passed (26 seconds)
Details
buildkite/fusion-plugin-react-redux/flowtype-node8 Passed (23 seconds)
Details
buildkite/fusion-plugin-react-redux/node-white-check-mark Passed (42 seconds)
Details
buildkite/fusion-plugin-react-redux/node-white-check-mark-node8 Passed (40 seconds)
Details
buildkite/fusion-plugin-react-redux/pipeline Passed (9 seconds)
Details
ci-gate Pull Request accepted for CI
codecov/patch 100% of diff hit (target 98.38%)
Details
codecov/project 98.38% (+0%) compared to 90db731
Details
license/cla Contributor License Agreement is signed.
Details
probot/label-docs-pr Docs label has been set (or unset)
probot/migrations Migration guide provided
probot/pr-label At least one required semver-related label exists
probot/pr-title PR title is valid
probot/release-verification Verification not required for this PR.
probot/todos All TODOs have open issues
@fusionjs-bot

This comment has been minimized.

Copy link

commented Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.