Skip to content
This repository has been archived by the owner. It is now read-only.

Update history module lib def #251

wants to merge 6 commits into
base: master


None yet
3 participants
Copy link

commented May 6, 2019

Testing changes from #250 along with flow-typed/flow-typed#3306.

KevinGrandon and others added some commits May 6, 2019

Change createBrowserHistory imports
The method of importing createBrowserHistory with `import createBrowserHistory from 'history/createBrowserHistory'` causes warning messages during testing. The message produced below includes an example of how to import the `createBrowserHistory` function. This change updates the code to be compatible with the intent of the message.

  console.error node_modules/history/warnAboutDeprecatedCJSRequire.js:17
    Warning: Please use `require("history").createBrowserHistory` instead of `require("history/createBrowserHistory")`. Support for the latter will be removed in the next major release.
Updated history package to 4.9.0
The import method for history required an update to v4.9.0.
Update plugin.js
Removed spaces.

This comment has been minimized.

Copy link

commented May 6, 2019

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
  Coverage   79.81%   79.81%           
  Files          10       10           
  Lines         218      218           
  Branches       48       48           
  Hits          174      174           
  Misses         30       30           
  Partials       14       14
Impacted Files Coverage Δ
src/plugin.js 85.24% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1558eda...5404012. Read the comment docs.

@KevinGrandon KevinGrandon changed the title WIP - Update history module lib def Update history module lib def May 8, 2019


angus-c approved these changes May 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.