Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow/tests/lint for all packages #373

Merged
merged 25 commits into from May 13, 2019

Conversation

Projects
None yet
3 participants
@micburks
Copy link
Contributor

commented May 10, 2019

Test PR to get all green lights in build plan

@KevinGrandon
Copy link
Contributor

left a comment

Thanks for fixing a lot of CI here! Maybe we should rename this PR if possible since it's doing a lot more than titled?

@micburks micburks changed the title Update use of deprecated API Fix flow/tests/lint for all packages May 13, 2019

@micburks

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Removed the original PR content and renamed

{gitignore: true}
{
gitignore: true,
ignore: ['node_modules']

This comment has been minimized.

Copy link
@micburks

micburks May 13, 2019

Author Contributor

This was preventing me from running this script locally

);

const filesPerJob = Math.ceil(allFiles.length / JOB_COUNT);
const filesPerJob = Math.floor(allFiles.length / JOB_COUNT);

This comment has been minimized.

Copy link
@micburks

micburks May 13, 2019

Author Contributor

If Math.ceil was rounding more than the number of tests per job, the last job was not being passed any paths. This was causing the final job to run all fusion-cli tests at once and timing out

@KevinGrandon
Copy link
Contributor

left a comment

Awesome, nice work!

@chrisdothtml

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Thanks again for fixing all this 👍

@KevinGrandon KevinGrandon dismissed stale reviews from chrisdothtml and themself via 474cc7d May 13, 2019

@KevinGrandon

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

Awesome pull request, thanks for the work here. We have one failing test in fusion-cli after rebasing, no idea why - will figure that out in a follow-up.

@KevinGrandon KevinGrandon merged commit 33419c2 into master May 13, 2019

42 of 45 checks passed

buildkite/fusionjs Build #551 failed (6 minutes, 59 seconds)
Details
buildkite/fusionjs/fusion-cli Failed (exit status 1)
Details
parent-monorepo/ci
buildkite/fusionjs/create-fusion-app Passed (1 minute, 11 seconds)
Details
buildkite/fusionjs/create-fusion-plugin Passed (1 minute, 2 seconds)
Details
buildkite/fusionjs/docker Passed (3 minutes, 48 seconds)
Details
buildkite/fusionjs/eslint Passed (56 seconds)
Details
buildkite/fusionjs/eslint-config-fusion Passed (39 seconds)
Details
buildkite/fusionjs/flowtype Passed (23 seconds)
Details
buildkite/fusionjs/fusion-core Passed (44 seconds)
Details
buildkite/fusionjs/fusion-plugin-apollo Passed (46 seconds)
Details
buildkite/fusionjs/fusion-plugin-browser-performance-emitter Passed (42 seconds)
Details
buildkite/fusionjs/fusion-plugin-connected-react-router Passed (45 seconds)
Details
buildkite/fusionjs/fusion-plugin-csrf-protection Passed (44 seconds)
Details
buildkite/fusionjs/fusion-plugin-error-handling Passed (47 seconds)
Details
buildkite/fusionjs/fusion-plugin-font-loader-react Passed (43 seconds)
Details
buildkite/fusionjs/fusion-plugin-http-handler Passed (42 seconds)
Details
buildkite/fusionjs/fusion-plugin-i18n Passed (45 seconds)
Details
buildkite/fusionjs/fusion-plugin-i18n-react Passed (43 seconds)
Details
buildkite/fusionjs/fusion-plugin-introspect Passed (41 seconds)
Details
buildkite/fusionjs/fusion-plugin-jwt Passed (44 seconds)
Details
buildkite/fusionjs/fusion-plugin-node-performance-emitter Passed (42 seconds)
Details
buildkite/fusionjs/fusion-plugin-react-helmet-async Passed (44 seconds)
Details
buildkite/fusionjs/fusion-plugin-react-redux Passed (47 seconds)
Details
buildkite/fusionjs/fusion-plugin-react-router Passed (1 minute, 6 seconds)
Details
buildkite/fusionjs/fusion-plugin-redux-action-emitter-enhancer Passed (1 minute, 5 seconds)
Details
buildkite/fusionjs/fusion-plugin-rpc Passed (1 minute, 5 seconds)
Details
buildkite/fusionjs/fusion-plugin-rpc-redux-react Passed (1 minute, 7 seconds)
Details
buildkite/fusionjs/fusion-plugin-service-worker Passed (1 minute, 16 seconds)
Details
buildkite/fusionjs/fusion-plugin-styletron-react Passed (26 seconds)
Details
buildkite/fusionjs/fusion-plugin-universal-events Passed (17 seconds)
Details
buildkite/fusionjs/fusion-plugin-universal-events-react Passed (13 seconds)
Details
buildkite/fusionjs/fusion-plugin-universal-logger Passed (16 seconds)
Details
buildkite/fusionjs/fusion-react Passed (17 seconds)
Details
buildkite/fusionjs/fusion-rpc-redux Passed (17 seconds)
Details
buildkite/fusionjs/fusion-scaffolder Passed (16 seconds)
Details
buildkite/fusionjs/fusion-test-utils Passed (16 seconds)
Details
buildkite/fusionjs/fusion-tokens Passed (14 seconds)
Details
buildkite/fusionjs/pipeline Passed (10 seconds)
Details
ci-gate Pull Request accepted for CI
license/cla Contributor License Agreement is signed.
Details
probot/label-docs-pr Docs label has been set (or unset)
probot/migrations Migration guide provided
probot/pr-title PR title is valid
probot/todos All TODOs have open issues

@fusionjs-bot fusionjs-bot bot deleted the mburks-patch-1 branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.