Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-Error promise rejections #385

Merged
merged 1 commit into from May 14, 2019

Conversation

Projects
None yet
2 participants
@KevinGrandon
Copy link
Contributor

commented May 13, 2019

It's possible to reject a non-Error value, so we should handle this and coerce it to an Error when that happens.

Handle non-Error promise rejections
It's possible to reject a non-Error value, so we should handle this and coerce it to an Error when that happens.

@KevinGrandon KevinGrandon force-pushed the handle-non-error-rejections branch from 9ff2fb3 to 4e95d41 May 13, 2019

@KevinGrandon KevinGrandon added the bugfix label May 14, 2019

@KevinGrandon

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

!merge

@fusionjs-bot fusionjs-bot bot merged commit 099eaec into master May 14, 2019

44 of 45 checks passed

parent-monorepo/ci
buildkite/fusionjs Build #562 passed (6 minutes, 59 seconds)
Details
buildkite/fusionjs/create-fusion-app Passed (1 minute, 7 seconds)
Details
buildkite/fusionjs/create-fusion-plugin Passed (1 minute, 1 second)
Details
buildkite/fusionjs/docker Passed (3 minutes, 22 seconds)
Details
buildkite/fusionjs/eslint Passed (1 minute, 27 seconds)
Details
buildkite/fusionjs/eslint-config-fusion Passed (36 seconds)
Details
buildkite/fusionjs/flowtype Passed (26 seconds)
Details
buildkite/fusionjs/fusion-cli Passed (2 minutes, 50 seconds)
Details
buildkite/fusionjs/fusion-core Passed (45 seconds)
Details
buildkite/fusionjs/fusion-plugin-apollo Passed (44 seconds)
Details
buildkite/fusionjs/fusion-plugin-browser-performance-emitter Passed (44 seconds)
Details
buildkite/fusionjs/fusion-plugin-connected-react-router Passed (46 seconds)
Details
buildkite/fusionjs/fusion-plugin-csrf-protection Passed (43 seconds)
Details
buildkite/fusionjs/fusion-plugin-error-handling Passed (47 seconds)
Details
buildkite/fusionjs/fusion-plugin-font-loader-react Passed (45 seconds)
Details
buildkite/fusionjs/fusion-plugin-http-handler Passed (43 seconds)
Details
buildkite/fusionjs/fusion-plugin-i18n Passed (43 seconds)
Details
buildkite/fusionjs/fusion-plugin-i18n-react Passed (41 seconds)
Details
buildkite/fusionjs/fusion-plugin-introspect Passed (43 seconds)
Details
buildkite/fusionjs/fusion-plugin-jwt Passed (52 seconds)
Details
buildkite/fusionjs/fusion-plugin-node-performance-emitter Passed (15 seconds)
Details
buildkite/fusionjs/fusion-plugin-react-helmet-async Passed (16 seconds)
Details
buildkite/fusionjs/fusion-plugin-react-redux Passed (18 seconds)
Details
buildkite/fusionjs/fusion-plugin-react-router Passed (16 seconds)
Details
buildkite/fusionjs/fusion-plugin-redux-action-emitter-enhancer Passed (14 seconds)
Details
buildkite/fusionjs/fusion-plugin-rpc Passed (16 seconds)
Details
buildkite/fusionjs/fusion-plugin-rpc-redux-react Passed (15 seconds)
Details
buildkite/fusionjs/fusion-plugin-service-worker Passed (1 minute, 13 seconds)
Details
buildkite/fusionjs/fusion-plugin-styletron-react Passed (24 seconds)
Details
buildkite/fusionjs/fusion-plugin-universal-events Passed (17 seconds)
Details
buildkite/fusionjs/fusion-plugin-universal-events-react Passed (13 seconds)
Details
buildkite/fusionjs/fusion-plugin-universal-logger Passed (15 seconds)
Details
buildkite/fusionjs/fusion-react Passed (15 seconds)
Details
buildkite/fusionjs/fusion-rpc-redux Passed (15 seconds)
Details
buildkite/fusionjs/fusion-scaffolder Passed (11 seconds)
Details
buildkite/fusionjs/fusion-test-utils Passed (14 seconds)
Details
buildkite/fusionjs/fusion-tokens Passed (13 seconds)
Details
buildkite/fusionjs/pipeline Passed (10 seconds)
Details
ci-gate Pull Request accepted for CI
license/cla Contributor License Agreement is signed.
Details
probot/label-docs-pr Docs label has been set (or unset)
probot/migrations Migration guide provided
probot/pr-title PR title is valid
probot/todos All TODOs have open issues

@fusionjs-bot fusionjs-bot bot deleted the handle-non-error-rejections branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.