Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Flow complaints in fusion-plugin-apollo #386

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
3 participants
@AlexMSmithCA
Copy link
Member

commented May 15, 2019

Resolves WPT-3239:

Updates Flow libdef for redux to resolve the following error:

$ flow check
Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ flow-typed/npm/redux_v4.x.x.js:15:43

Deprecated utility. Using $Subtype types is not recommended! (deprecated-utility)

     12│   */
     13│
     14│   declare export type DispatchAPI<A> = (action: A) => A;
     15│   declare export type Dispatch<A: { type: $Subtype<string> }> = DispatchAPI<A>;
     16│
     17│   declare export type MiddlewareAPI<S, A, D = Dispatch<A>> = {
     18│     dispatch: D;



Found 1 error
error Command failed with exit code 2.

@AlexMSmithCA AlexMSmithCA self-assigned this May 15, 2019

@AlexMSmithCA AlexMSmithCA changed the title WPT-3239 - Resolves Flow complaints in fusion-plugin-apollo Resolves Flow complaints in fusion-plugin-apollo May 15, 2019

@AlexMSmithCA AlexMSmithCA changed the title Resolves Flow complaints in fusion-plugin-apollo Resolve Flow complaints in fusion-plugin-apollo May 15, 2019

@AlexMSmithCA AlexMSmithCA added the bugfix label May 15, 2019

@chrisdothtml chrisdothtml force-pushed the resolve-flow-in-fusion-plugin-apollo branch from 7ed69be to 9552d65 May 15, 2019

@chrisdothtml

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Rebased off master

@AlexMSmithCA AlexMSmithCA merged commit 1f889f1 into master May 16, 2019

44 of 45 checks passed

parent-monorepo/ci
buildkite/fusionjs Build #570 passed (6 minutes, 55 seconds)
Details
buildkite/fusionjs/create-fusion-app Passed (1 minute, 27 seconds)
Details
buildkite/fusionjs/create-fusion-plugin Passed (1 minute, 21 seconds)
Details
buildkite/fusionjs/docker Passed (3 minutes, 32 seconds)
Details
buildkite/fusionjs/eslint Passed (57 seconds)
Details
buildkite/fusionjs/eslint-config-fusion Passed (59 seconds)
Details
buildkite/fusionjs/flowtype Passed (23 seconds)
Details
buildkite/fusionjs/fusion-cli Passed (3 minutes, 12 seconds)
Details
buildkite/fusionjs/fusion-core Passed (1 minute, 6 seconds)
Details
buildkite/fusionjs/fusion-plugin-apollo Passed (1 minute, 4 seconds)
Details
buildkite/fusionjs/fusion-plugin-browser-performance-emitter Passed (1 minute, 5 seconds)
Details
buildkite/fusionjs/fusion-plugin-connected-react-router Passed (46 seconds)
Details
buildkite/fusionjs/fusion-plugin-csrf-protection Passed (45 seconds)
Details
buildkite/fusionjs/fusion-plugin-error-handling Passed (16 seconds)
Details
buildkite/fusionjs/fusion-plugin-font-loader-react Passed (14 seconds)
Details
buildkite/fusionjs/fusion-plugin-http-handler Passed (14 seconds)
Details
buildkite/fusionjs/fusion-plugin-i18n Passed (13 seconds)
Details
buildkite/fusionjs/fusion-plugin-i18n-react Passed (13 seconds)
Details
buildkite/fusionjs/fusion-plugin-introspect Passed (42 seconds)
Details
buildkite/fusionjs/fusion-plugin-jwt Passed (44 seconds)
Details
buildkite/fusionjs/fusion-plugin-node-performance-emitter Passed (13 seconds)
Details
buildkite/fusionjs/fusion-plugin-react-helmet-async Passed (45 seconds)
Details
buildkite/fusionjs/fusion-plugin-react-redux Passed (18 seconds)
Details
buildkite/fusionjs/fusion-plugin-react-router Passed (16 seconds)
Details
buildkite/fusionjs/fusion-plugin-redux-action-emitter-enhancer Passed (13 seconds)
Details
buildkite/fusionjs/fusion-plugin-rpc Passed (15 seconds)
Details
buildkite/fusionjs/fusion-plugin-rpc-redux-react Passed (45 seconds)
Details
buildkite/fusionjs/fusion-plugin-service-worker Passed (1 minute, 41 seconds)
Details
buildkite/fusionjs/fusion-plugin-styletron-react Passed (24 seconds)
Details
buildkite/fusionjs/fusion-plugin-universal-events Passed (16 seconds)
Details
buildkite/fusionjs/fusion-plugin-universal-events-react Passed (42 seconds)
Details
buildkite/fusionjs/fusion-plugin-universal-logger Passed (13 seconds)
Details
buildkite/fusionjs/fusion-react Passed (16 seconds)
Details
buildkite/fusionjs/fusion-rpc-redux Passed (15 seconds)
Details
buildkite/fusionjs/fusion-scaffolder Passed (11 seconds)
Details
buildkite/fusionjs/fusion-test-utils Passed (1 minute, 4 seconds)
Details
buildkite/fusionjs/fusion-tokens Passed (16 seconds)
Details
buildkite/fusionjs/pipeline Passed (10 seconds)
Details
ci-gate Pull Request accepted for CI
license/cla Contributor License Agreement is signed.
Details
probot/label-docs-pr Docs label has been set (or unset)
probot/migrations Migration guide provided
probot/pr-title PR title is valid
probot/todos All TODOs have open issues

@fusionjs-bot fusionjs-bot bot deleted the resolve-flow-in-fusion-plugin-apollo branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.