Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Updates for Operator Panel #4170
Thanks for taking a look at it. Can you clarify what you mean by "introduces risk in another area"?
All of the commented code appears to be unused/unreachable through normal use, because the front end code never uses the "action" parameter. For example, changing the agent status still works with these changes because that is handled by code in index.php rather than exec.php, with a request like /app/operator_panel/index.php?status=Do%20Not%Disturb. The code that makes the request is here:
Is that incorrect?
Sure sorry about causing the conflict. I do see that your changes are needed.…
On Thu, May 30, 2019 at 3:06 PM danbgds ***@***.***> wrote: If you're open to these changes, we can resubmit them against basic_operator_panel. Even if you're planning on refactoring the module in the future, it'd be beneficial to lock this stuff down in the meantime. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4170?email_source=notifications&email_token=AA2AE7M2VQ3BPVXE2P4753LPYA6ULA5CNFSM4HOVUIK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWTQSKI#issuecomment-497486121>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2AE7LX6WFT5W36ZFEMMQDPYA6ULANCNFSM4HOVUIKQ> .