Update broker setup for broker in origin template #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this with and without For the non-rcm case I pointed it at my local template as openshift/ansible-service-broker#410 is not yet merged. |
djzager
changed the title
rthallisey
reviewed
Aug 30, 2017
| - name: Get route for ansible-service-broker | ||
| shell: "'{{ oc_cmd }}' get routes | grep ansible-service-broker | awk '{print $2}'" | ||
| register: result_get_route_asb | ||
| retries: 6 | ||
| delay: 10 | ||
| when: "rcm" |
There was a problem hiding this comment.
We can still check if the route was created whether this is rcm or not
|
depends-on: openshift/ansible-service-broker#410 |
After updating the deployment template in the broker, we need for catasb to *not* try and create the broker resource. The only case that catasb should update the resource is in the case of an older broker `rcm=true`.
djzager
force-pushed
the
broker-in-template
branch
from
58810a1
to
12e97f9
Compare
djzager
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the deployment template in the broker, we need for catasb
to not try and create the broker resource. The only case that catasb
should update the resource is in the case of an older broker
rcm=true.