1356290 - get pids from portal when adding subs #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrodri
changed the title
jmrodri
changed the title
Fix validation when adding subscription during deployments creation
If you add subscriptions to your manifest during deployment which did not exist before, we need to go to the portal to get the product ids so that we can validate them as well as the counts. WOW that's a run on sentence isn't it? * remove trailing whitespace
|
@eriknelson if you get a chance can you look this PR over please. |
|
Verified this PR fixes the attached/trello bz. Discovered a race condition that makes it appear to fail in the front end, but it's not an issue with this server code. Front-end race condition PR -> #1067 ACK! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you add subscriptions to your manifest during deployment which did not exist
before, we need to go to the portal to get the product ids so that we can
validate them as well as the counts.
WOW that's a run on sentence isn't it?