New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved NFS validation to RHEV configuration #941

Merged
merged 2 commits into from Jun 13, 2016

Conversation

Projects
None yet
4 participants
@dymurray
Contributor

dymurray commented Jun 10, 2016

This validates the NFS share before continuing to step 3. A known issue currently is that invalid shares could take a long time to validate due to NFS timeouts taking almost 2 minutes. We have plans to address this.

@dymurray

This comment has been minimized.

Show comment
Hide comment
@dymurray

dymurray Jun 10, 2016

Contributor

Rubocop will fail because I am making a change to the safe-mount script to take in the type. I will then update this PR to pass type into the safe-mount script.

Contributor

dymurray commented Jun 10, 2016

Rubocop will fail because I am making a change to the safe-mount script to take in the type. I will then update this PR to pass type into the safe-mount script.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage decreased (-0.3%) to 66.648% when pulling 1ed41f8 on dymurray:nfs_update into 4a0d9f7 on fusor:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage decreased (-0.3%) to 66.648% when pulling 1ed41f8 on dymurray:nfs_update into 4a0d9f7 on fusor:master.

@dymurray dymurray changed the title from [WIP] Moved NFS validation to RHEV configuration to Moved NFS validation to RHEV configuration Jun 10, 2016

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage decreased (-0.2%) to 66.762% when pulling 65b4de3 on dymurray:nfs_update into 4a0d9f7 on fusor:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage decreased (-0.2%) to 66.762% when pulling 65b4de3 on dymurray:nfs_update into 4a0d9f7 on fusor:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage decreased (-0.2%) to 66.724% when pulling 4dd6a1a on dymurray:nfs_update into 4a0d9f7 on fusor:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage decreased (-0.2%) to 66.724% when pulling 4dd6a1a on dymurray:nfs_update into 4a0d9f7 on fusor:master.

@dymurray dymurray changed the title from Moved NFS validation to RHEV configuration to [WIP] Moved NFS validation to RHEV configuration Jun 10, 2016

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling 3e88262 on dymurray:nfs_update into 4a0d9f7 on fusor:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling 3e88262 on dymurray:nfs_update into 4a0d9f7 on fusor:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling bcc1c1e on dymurray:nfs_update into 4a0d9f7 on fusor:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling bcc1c1e on dymurray:nfs_update into 4a0d9f7 on fusor:master.

@eriknelson

This comment has been minimized.

Show comment
Hide comment
@eriknelson

eriknelson Jun 10, 2016

Contributor

ACK pending my last comment and travis. Thanks @dymurray

Contributor

eriknelson commented Jun 10, 2016

ACK pending my last comment and travis. Thanks @dymurray

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling a10d216 on dymurray:nfs_update into 5872169 on fusor:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling a10d216 on dymurray:nfs_update into 5872169 on fusor:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling 314107b on dymurray:nfs_update into 5872169 on fusor:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling 314107b on dymurray:nfs_update into 5872169 on fusor:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling 73be479 on dymurray:nfs_update into 5872169 on fusor:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling 73be479 on dymurray:nfs_update into 5872169 on fusor:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling e6e8ef8 on dymurray:nfs_update into 5872169 on fusor:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling e6e8ef8 on dymurray:nfs_update into 5872169 on fusor:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling 8017a99 on dymurray:nfs_update into 5872169 on fusor:master.

coveralls commented Jun 10, 2016

Coverage Status

Coverage increased (+0.2%) to 67.105% when pulling 8017a99 on dymurray:nfs_update into 5872169 on fusor:master.

Updated promises and server methods
Updated safe mount options for gluster

Added unit test to controller for check_mount_point

@dymurray dymurray changed the title from [WIP] Moved NFS validation to RHEV configuration to Moved NFS validation to RHEV configuration Jun 13, 2016

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 13, 2016

Coverage Status

Coverage increased (+0.2%) to 67.123% when pulling 798dcb7 on dymurray:nfs_update into 1fef03a on fusor:master.

coveralls commented Jun 13, 2016

Coverage Status

Coverage increased (+0.2%) to 67.123% when pulling 798dcb7 on dymurray:nfs_update into 1fef03a on fusor:master.

@dymurray dymurray merged commit 98e700e into fusor:master Jun 13, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 67.123%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment