Add const-wide/32 bytecode parser and n4/o test case #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented missing const-wide/32 (opcode 0x17) parser in dalvikBytecodeParser.ts - Added const-wide/32 to smaliParser's operationsWithBigintValue set - Added n4/o test case to testCasesByCid for CID bafybeiebe27ylo53trgitu6fqfbmba43c4ivxj3nt4kumsilkucpbdxtqq - All 44 tests now passing Co-authored-by: futpib <4330357+futpib@users.noreply.github.com>
Pull Request Test Coverage Report for Build 19325591317Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 19325743291Details
💛 - Coveralls |
Copilot
AI
changed the title
[WIP] Add parseDexAgainstSmaliMacro test to pass like others
Add const-wide/32 bytecode parser and n4/o test case
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
n4/oclass from CIDbafybeiebe27ylo53trgitu6fqfbmba43c4ivxj3nt4kumsilkucpbdxtqqfailed to parse because the DALvik bytecode parser was missing support for theconst-wide/32instruction (opcode 0x17).Changes
const-wide/32(opcode 0x17) parser using format 31i, following the same pattern asconst-wide/16(0x16) andconst-wide(0x18)const-wide/32tooperationsWithBigintValueset for correct BigInt value handlingn4/otest caseThe
const-wide/32instruction sign-extends a 32-bit value to 64-bit, bridging the gap betweenconst-wide/16(16-bit) andconst-wide(64-bit) in the instruction set.Original prompt
bafybeiebe27ylo53trgitu6fqfbmba43c4ivxj3nt4kumsilkucpbdxtqq+n4/oparseDexAgainstSmaliMacro test like others and make it pass #131💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.