Skip to content

Complete reverseRegistersOperations set for 12x format Dalvik bytecode operations #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
futpib merged 2 commits into from
Nov 10, 2025
Merged

Complete reverseRegistersOperations set for 12x format Dalvik bytecode operations #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b88648
Initial plan
Copilot Nov 10, 2025
a66ba4f
Fix register order for all 12x format operations in smaliParser
Copilot Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 59 additions & 1 deletion src/smaliParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1636,21 +1636,79 @@ const sortRegistersOperations = new Set<DalvikBytecodeOperation['operation']>([
'if-ne',
]);

// TODO: ???
// All 12x format operations need register reversal because:
// - Bytecode format is B|A (B in high nibble, A in low nibble)
// - nibblesParser returns [B, A]
// - Smali syntax is "op vA, vB" (destination first)
// - So we need to reverse to get [A, B]
const reverseRegistersOperations = new Set<DalvikBytecodeOperation['operation']>([
// Move operations
'move',
'move-wide',
'move-object',

// Unary operations (negation, bitwise not)
'neg-int',
'not-int',
'neg-long',
'not-long',
'neg-float',
'neg-double',

// Type conversion operations
'int-to-long',
'int-to-float',
'int-to-double',
'long-to-int',
'long-to-float',
'long-to-double',
'float-to-int',
'float-to-long',
'float-to-double',
'double-to-int',
'double-to-long',
'double-to-float',
'int-to-byte',
'int-to-char',
'int-to-short',

// Binary operations with /2addr suffix
'add-int/2addr',
'sub-int/2addr',
'mul-int/2addr',
'div-int/2addr',
'rem-int/2addr',
'and-int/2addr',
'or-int/2addr',
'xor-int/2addr',
'shl-int/2addr',
'shr-int/2addr',
'ushr-int/2addr',

'add-long/2addr',
'mul-long/2addr',
'div-long/2addr',
'rem-long/2addr',
'and-long/2addr',
'or-long/2addr',
'xor-long/2addr',
'shl-long/2addr',
'shr-long/2addr',
'ushr-long/2addr',

'add-float/2addr',
'sub-float/2addr',
'mul-float/2addr',
'div-float/2addr',

'add-double/2addr',
'sub-double/2addr',
'mul-double/2addr',
'div-double/2addr',
'rem-double/2addr',

// Reverse subtract (also 12x format)
'rsub-long',
]);

function normalizeOperation(operation: DalvikBytecodeOperation): DalvikBytecodeOperation {
Expand Down