New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job queue worries (was: deal with too big a queues) #34

Open
futtta opened this Issue Jun 18, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@futtta
Owner

futtta commented Jun 18, 2018

some users are reporting huge queues (I suppose they're on slow hosts and more items are added then there are processed, to be looked into).

but to keep things manageable (or to give users some control over this), we could look into:

  • a button "clear queue" for the user to press when things get too intense ('p' jobs should stay I guess)
  • a mechanism to purge "N" queue items older then X hours (days) if queuelength > Y items

@futtta futtta added the draft spec label Jun 18, 2018

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Jun 18, 2018

Owner

feedback welcome @denydias

Owner

futtta commented Jun 18, 2018

feedback welcome @denydias

@denydias

This comment has been minimized.

Show comment
Hide comment
@denydias

denydias Jun 18, 2018

Collaborator

First things first: define 'huge'. How many jobs you consider a huge queue?

Collaborator

denydias commented Jun 18, 2018

First things first: define 'huge'. How many jobs you consider a huge queue?

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Jun 18, 2018

Owner
Owner

futtta commented Jun 18, 2018

@denydias

This comment has been minimized.

Show comment
Hide comment
@denydias

denydias Jun 18, 2018

Collaborator

Hummm... I think that the solution for hundreds and thousands of jobs in the queue is to decrease the time between queue runs. Maybe ask those users with huge queues to install something like wp-control so they can change the default queue interval from 10 minutes to, let's say, five, three or even one minute.

The thing to clear the queue or purge N jobs falls into the category of inefficiency. The plugin will recreate those jobs anyway. As such this will be a tool so a user can fool himself. It's pure eye candy.

If the size of the queue is something to bother, we should just hide the queue somewhere in the UI. Jobs are far less important than rules.

Collaborator

denydias commented Jun 18, 2018

Hummm... I think that the solution for hundreds and thousands of jobs in the queue is to decrease the time between queue runs. Maybe ask those users with huge queues to install something like wp-control so they can change the default queue interval from 10 minutes to, let's say, five, three or even one minute.

The thing to clear the queue or purge N jobs falls into the category of inefficiency. The plugin will recreate those jobs anyway. As such this will be a tool so a user can fool himself. It's pure eye candy.

If the size of the queue is something to bother, we should just hide the queue somewhere in the UI. Jobs are far less important than rules.

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Aug 17, 2018

Owner

job queue is now hidden when there is one (or more) AUTO rules, see 8fe7c98

Owner

futtta commented Aug 17, 2018

job queue is now hidden when there is one (or more) AUTO rules, see 8fe7c98

@futtta futtta changed the title from new feature: deal with too big a queues to new feature: make job queue less prominent (was: deal with too big a queues) Aug 17, 2018

@futtta futtta added this to the 1.8.0 milestone Aug 17, 2018

@futtta futtta added to be tested and removed draft spec labels Aug 17, 2018

@futtta futtta removed the to be tested label Aug 20, 2018

@futtta futtta closed this Aug 20, 2018

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Sep 3, 2018

Owner

I'm reconsider auto-purging old(er) N jobs as I saw a user with 1111 jobs, some of which were 5 days old already even though, given the fact he does have AUTO rules, cron is working.

Even if the jobs-panel is hidden and psychological impact is somewhat mitigated, having that amount of N jobs means that the plugin is constantly "running behind the facts" and that the hash stored in the job might already be not be correct any more when the CCSS is actually requested, leading to the job being re-created with a new hash which potentially is incorrect again when the job gets executed ... ad infinitum ....

Owner

futtta commented Sep 3, 2018

I'm reconsider auto-purging old(er) N jobs as I saw a user with 1111 jobs, some of which were 5 days old already even though, given the fact he does have AUTO rules, cron is working.

Even if the jobs-panel is hidden and psychological impact is somewhat mitigated, having that amount of N jobs means that the plugin is constantly "running behind the facts" and that the hash stored in the job might already be not be correct any more when the CCSS is actually requested, leading to the job being re-created with a new hash which potentially is incorrect again when the job gets executed ... ad infinitum ....

@futtta futtta reopened this Sep 3, 2018

@futtta futtta changed the title from new feature: make job queue less prominent (was: deal with too big a queues) to job queue worries (was: deal with too big a queues) Sep 3, 2018

@futtta futtta modified the milestones: 1.8.0, 1.9.0 Sep 8, 2018

@futtta futtta added the to be tested label Sep 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment