New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(option to) disable CCSS injection for logged in users #48

Closed
futtta opened this Issue Jul 20, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@futtta
Owner

futtta commented Jul 20, 2018

as:

  • CCSS can only be fetched for anonymous users
  • CSS can (and often is) different for logged on users

shouldn't we simply not inject CCSS for logged on users?

disadvantage; users might claim it doesn't work, as they would not see the CCSS when doing view-source in their active browser-session (they would need switch to a different browser/ private session).

@pocketjoso

This comment has been minimized.

Show comment
Hide comment
@pocketjoso

pocketjoso Jul 20, 2018

Imo let's just explain that they should check the site logged out to see it with critical css. (unless they change this setting - at their own responsibility)

pocketjoso commented Jul 20, 2018

Imo let's just explain that they should check the site logged out to see it with critical css. (unless they change this setting - at their own responsibility)

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Jul 20, 2018

Owner
Owner

futtta commented Jul 20, 2018

@pocketjoso

This comment has been minimized.

Show comment
Hide comment
@pocketjoso

pocketjoso Jul 20, 2018

the question is; for how many users does the CCSS break the logged in pages
even after the full CSS has loaded. this should be a small percentage.

It's not enough that the full render fixes it, if it's broken at the first render it's a no-go.

and if it doesn't break final rendering, then having the CCSS in place does
allow for faster rendering of the page (albeit without the elements that
are for logged-in users only.

Only if the full css is not cached. Which it should be after the first visit. Yes, there are definitively cases where a logged in user returns later, and the css they have cached is no longer the latest.. but it's not worth breaking pages just to support this use case. Critical css is really primarily meant for the first visit, which will always be on logged out pages.

pocketjoso commented Jul 20, 2018

the question is; for how many users does the CCSS break the logged in pages
even after the full CSS has loaded. this should be a small percentage.

It's not enough that the full render fixes it, if it's broken at the first render it's a no-go.

and if it doesn't break final rendering, then having the CCSS in place does
allow for faster rendering of the page (albeit without the elements that
are for logged-in users only.

Only if the full css is not cached. Which it should be after the first visit. Yes, there are definitively cases where a logged in user returns later, and the css they have cached is no longer the latest.. but it's not worth breaking pages just to support this use case. Critical css is really primarily meant for the first visit, which will always be on logged out pages.

@futtta futtta added this to the 1.6.0 milestone Jul 24, 2018

@futtta futtta closed this Jul 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment