New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inc/core.php: match path with urldecoded $_SERVER['REQUEST_URI']? #54

Closed
futtta opened this Issue Aug 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@futtta
Owner

futtta commented Aug 5, 2018

cfr. https://wordpress.org/support/topic/full-css-not-critical-in-body-of-the-html-document/#post-10556934

user had path-based rules with cyrillic characters which did not match, he converted them to urlencoded strings and it did work, so maybe we should urldecode($_SERVER['REQUEST_URI']) in the path-based logic in inc/core.php

makes sense to you @denydias or am I forgetting something here?

@futtta futtta added the question label Aug 5, 2018

@denydias

This comment has been minimized.

Show comment
Hide comment
@denydias

denydias Aug 7, 2018

Collaborator

Sorry for the late reply, @futtta. Yes, urldecode() should be enough for that use case.

Collaborator

denydias commented Aug 7, 2018

Sorry for the late reply, @futtta. Yes, urldecode() should be enough for that use case.

@futtta futtta added this to the 1.7.0 milestone Aug 9, 2018

@futtta futtta closed this Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment