New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

differenciate API key check fail between "bad key" and "other error" #64

Open
futtta opened this Issue Sep 7, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@futtta
Owner

futtta commented Sep 7, 2018

currently if a user somehow blocks outgoing requests, we still show the "wrong api key" error. it would be better to show a "could not check" or "there seems to be a problem" error instead to be able to differentiate between the two.

@denydias

This comment has been minimized.

Show comment
Hide comment
@denydias

denydias Sep 8, 2018

Collaborator

The 'other error' may be triggered by a curl timeout. It's possible to differentiate it from a 'bad key', but it's not possible to discover what caused the timeout itself to provide a better message. Is that ok?

Collaborator

denydias commented Sep 8, 2018

The 'other error' may be triggered by a curl timeout. It's possible to differentiate it from a 'bad key', but it's not possible to discover what caused the timeout itself to provide a better message. Is that ok?

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Sep 8, 2018

Owner
Owner

futtta commented Sep 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment