New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow requests to ao_speedup_cachebuster #104

Closed
mckernanin opened this Issue Jul 19, 2017 · 10 comments

Comments

3 participants
@mckernanin

mckernanin commented Jul 19, 2017

Hello,
I have the plugin active on a staging site, and on every page load there's a 3-4 second request to /?ao_speedup_cachebuster. Sometimes it fires twice. Using a simple profiling plugin, here's a screenshot:

https://www.dropbox.com/s/stp43whmins1edf/Screenshot%202017-07-19%2012.05.17.png?dl=0

Site is running on ServerPilot, php7.1, WP 4.8. Let me know if you need any other info, happy to help track this down!

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Jul 19, 2017

Owner

weird; that code runs as part of autoptimizeCache::clearall in classes/autoptimizeCache.php and thus only gets executed when the cache has been cleared to preload it again immediately after that. so the question is; why (what) is triggering autoptimize::clearall?

Owner

futtta commented Jul 19, 2017

weird; that code runs as part of autoptimizeCache::clearall in classes/autoptimizeCache.php and thus only gets executed when the cache has been cleared to preload it again immediately after that. so the question is; why (what) is triggering autoptimize::clearall?

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Jul 24, 2017

Owner

did you have the time to investigate further @mckernanin ?

Owner

futtta commented Jul 24, 2017

did you have the time to investigate further @mckernanin ?

@mckernanin

This comment has been minimized.

Show comment
Hide comment
@mckernanin

mckernanin Jul 25, 2017

I have not, will try to soon.

mckernanin commented Jul 25, 2017

I have not, will try to soon.

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Sep 27, 2017

Owner

@mckernanin no news yet, but that is good news maybe? :-)

Owner

futtta commented Sep 27, 2017

@mckernanin no news yet, but that is good news maybe? :-)

@futtta futtta closed this Dec 6, 2017

@PatTheMav

This comment has been minimized.

Show comment
Hide comment
@PatTheMav

PatTheMav Jan 4, 2018

@futtta - FYI, faced the same issue on my blog, with the cache buster call being constantly triggered and hammering my whole FPM pool. Fully disabling and re-enabling Autoptimize seemed to have fixed it.

PatTheMav commented Jan 4, 2018

@futtta - FYI, faced the same issue on my blog, with the cache buster call being constantly triggered and hammering my whole FPM pool. Fully disabling and re-enabling Autoptimize seemed to have fixed it.

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Jan 4, 2018

Owner

@PatTheMav this has been diagnosed as a problem with stale options ("alloptions") in external object caches (redis, memcached, ...) causing AO to continuously going through the "update"-procedure, including clearing the cache and preloading it (cfr. the cachebuster requests) and is fixed (well, worked around as it's a core issue) in the upcoming 2.3.2, cfr. this commit.

quite the bug ... :-/

Owner

futtta commented Jan 4, 2018

@PatTheMav this has been diagnosed as a problem with stale options ("alloptions") in external object caches (redis, memcached, ...) causing AO to continuously going through the "update"-procedure, including clearing the cache and preloading it (cfr. the cachebuster requests) and is fixed (well, worked around as it's a core issue) in the upcoming 2.3.2, cfr. this commit.

quite the bug ... :-/

@PatTheMav

This comment has been minimized.

Show comment
Hide comment
@PatTheMav

PatTheMav Jan 4, 2018

@futtta - yeah I also had the redis-cache in mind, but I just disabled most adding wholesale and re-enabled them one by one. Then it worked and I couldn't debug it any further anymore.

PatTheMav commented Jan 4, 2018

@futtta - yeah I also had the redis-cache in mind, but I just disabled most adding wholesale and re-enabled them one by one. Then it worked and I couldn't debug it any further anymore.

@mckernanin

This comment has been minimized.

Show comment
Hide comment
@mckernanin

mckernanin Jan 4, 2018

Ahhhhh, that makes sense. I was using redis on the site in question.

mckernanin commented Jan 4, 2018

Ahhhhh, that makes sense. I was using redis on the site in question.

@futtta

This comment has been minimized.

Show comment
Hide comment
@futtta

futtta Jan 4, 2018

Owner

this sure is a core bug that deserves an urgent fix after over 2 years of discussion, certainly when taking into account they have a working fix (well, workaround) for WP VIP for 2y already ...

Owner

futtta commented Jan 4, 2018

this sure is a core bug that deserves an urgent fix after over 2 years of discussion, certainly when taking into account they have a working fix (well, workaround) for WP VIP for 2y already ...

@PatTheMav

This comment has been minimized.

Show comment
Hide comment
@PatTheMav

PatTheMav Jan 4, 2018

Sounds like a typical Wordpress thing.. That beast needs to be rewritten from scratch, but that will probably never happen. 😅

PatTheMav commented Jan 4, 2018

Sounds like a typical Wordpress thing.. That beast needs to be rewritten from scratch, but that will probably never happen. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment