Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS inlined in embed pages #260

Open
vijayaraghavanramanan opened this issue Jul 2, 2019 · 8 comments

Comments

@vijayaraghavanramanan
Copy link

commented Jul 2, 2019

Wordpress has embed pages with their permalinks such as:

https://www.example.com/2019/07/02/hello-world/embed

This is an HTML page and has its own style, typically by Wordpress and not themes.

https://github.com/WordPress/WordPress/blob/1d98a92fad2992200dad9352eee456eaddc454be/wp-includes/embed.php#L1021

But if a user chooses inline and defer optimisation in Autoptimize, the critical css is inlined in the embed page too, although it doesn't seem to affect the styles.

But may be it's best to not add the critical css in embed pages?

@futtta

This comment has been minimized.

Copy link
Owner

commented Jul 2, 2019

@vijayaraghavanramanan

This comment has been minimized.

Copy link
Author

commented Jul 2, 2019

I guess so, since it's a core Wordpress feature?

@futtta

This comment has been minimized.

Copy link
Owner

commented Jul 2, 2019

@vijayaraghavanramanan

This comment has been minimized.

Copy link
Author

commented Jul 2, 2019

Oh, that way! Yes, maybe just do nothing/return if the url is an embed.

@futtta

This comment has been minimized.

Copy link
Owner

commented Jul 3, 2019

@futtta

This comment has been minimized.

Copy link
Owner

commented Jul 23, 2019

should be fixed in 2.6.0-beta-1 @vijayaraghavanramanan

@vijayaraghavanramanan

This comment has been minimized.

Copy link
Author

commented Jul 23, 2019

@vijayaraghavanramanan

This comment has been minimized.

Copy link
Author

commented Aug 23, 2019

Very late reply! Tested. Works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.