log alerts for unreadable CSS #78

Closed
drzraf opened this Issue Jan 24, 2017 · 4 comments

Comments

2 participants
@drzraf

drzraf commented Jan 24, 2017

When developing an asset may be unavailable.
If autoptimize is off, a 404 is triggered that helps spotting the problem.
But is autoptimize is on, CSS content is simply dropped which lead to a partial compressed CSS without notification. This could be misleading.

@futtta

This comment has been minimized.

Show comment Hide comment
@futtta

futtta Jan 24, 2017

Owner

errr .... well, I think the problem you're referring to exists in the current version (2.1.0) but is effectively fixed here on the GitHub (development) version with this commit which has AO bail from aggregating the file if it cannot be found/ read?

Owner

futtta commented Jan 24, 2017

errr .... well, I think the problem you're referring to exists in the current version (2.1.0) but is effectively fixed here on the GitHub (development) version with this commit which has AO bail from aggregating the file if it cannot be found/ read?

@futtta futtta added the question label Jan 24, 2017

@drzraf

This comment has been minimized.

Show comment Hide comment
@drzraf

drzraf Jan 24, 2017

It's not aggregated, but is there somehow a trace of this failure in a log so that the issue can be seen and fixed?

drzraf commented Jan 24, 2017

It's not aggregated, but is there somehow a trace of this failure in a log so that the issue can be seen and fixed?

@futtta

This comment has been minimized.

Show comment Hide comment
@futtta

futtta Jan 24, 2017

Owner

no, AO doesn't do any error-logging (yet, it may in the future although the question of what to log when is not an easy one, logs could quickly become very large), but as without AO this change ensures that;

a 404 is triggered that helps spotting the problem

:-)

Owner

futtta commented Jan 24, 2017

no, AO doesn't do any error-logging (yet, it may in the future although the question of what to log when is not an easy one, logs could quickly become very large), but as without AO this change ensures that;

a 404 is triggered that helps spotting the problem

:-)

@futtta

This comment has been minimized.

Show comment Hide comment
@futtta

futtta Jan 28, 2017

Owner

closing as fixed on DEV-version.

Owner

futtta commented Jan 28, 2017

closing as fixed on DEV-version.

@futtta futtta closed this Jan 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment