Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

log alerts for unreadable CSS #78

Closed
drzraf opened this Issue Jan 24, 2017 · 4 comments

Comments

Projects
None yet
2 participants

drzraf commented Jan 24, 2017

When developing an asset may be unavailable.
If autoptimize is off, a 404 is triggered that helps spotting the problem.
But is autoptimize is on, CSS content is simply dropped which lead to a partial compressed CSS without notification. This could be misleading.

Owner

futtta commented Jan 24, 2017 edited

errr .... well, I think the problem you're referring to exists in the current version (2.1.0) but is effectively fixed here on the GitHub (development) version with this commit which has AO bail from aggregating the file if it cannot be found/ read?

@futtta futtta added the question label Jan 24, 2017

drzraf commented Jan 24, 2017 edited

It's not aggregated, but is there somehow a trace of this failure in a log so that the issue can be seen and fixed?

Owner

futtta commented Jan 24, 2017

no, AO doesn't do any error-logging (yet, it may in the future although the question of what to log when is not an easy one, logs could quickly become very large), but as without AO this change ensures that;

a 404 is triggered that helps spotting the problem

:-)

Owner

futtta commented Jan 28, 2017

closing as fixed on DEV-version.

@futtta futtta closed this Jan 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment