Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Imgopt reorg with tweaks #197
so what's your opinion; push this in 2.4.1 or not? I like to keep the delta of minors as small as possible, but ...…
On Thu, Oct 4, 2018 at 3:04 PM zytzagoo ***@***.***> wrote: @zytzagoo <https://github.com/zytzagoo> requested your review on: futtta/autoptimize#197 <#197> Imgopt reorg with tweaks. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#197 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALEMaGka1AgLYU_U7i2Qo7_5Do61krQks5uhgd1gaJpZM4XIEEQ> .
It shouldn't change functionally, apart from some improvements/fixes mentioned in the commits above -- and those tests that were in the suite still pass.
It incorporates changes/fixes done on beta so far (with regards to imgopt stuff).
How else can we test this?
I think it should be safe to go in the next minor release really, but I understand the fear :)
Can we merge in beta branch and bump the beta version so it gets out to some of beta users before releasing as 2.4.1?
I think we need to do this differently after all @zytzagoo, I'd like to propose;
Goal is simply to keep "minor" releases really minor, only addressing real-life bugs (or small improvements) with a minimum of code changes with the simple goal to limit the risk or regressions.
Maybe I'm just being too careful, but I'd rather be too careful and not drown in support questions of which there have been a lot after 2.4.0 ;-)