Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid AMP pages caused by dnt_config script tag and the Automattic AMP plugin #1

Closed
16patsle opened this issue Jun 26, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@16patsle
Copy link

commented Jun 26, 2018

My Google Search Console recently started complaining about a line like this, which somehow was kept even on the AMP version of my site.

<script type="text/javascript">var dnt_config={ifdnt:"0",mode:"blacklist",black:["media6degrees.com","quantserve.com","lockerz.com"],white:[]};</script>

Is there something that can be done about this, so that the AMP plugin automatically filters it, like it does with all the other scripts? Or would it be something the AMP plugin needs to handle?

Relevant part of this plugin
AMP plugin by Automattic
German article describing the same issue

futtta added a commit that referenced this issue Jun 26, 2018

@futtta

This comment has been minimized.

Copy link
Owner

commented Jun 26, 2018

can you check that commit (or the full zipfile) @16patsle ?

@16patsle

This comment has been minimized.

Copy link
Author

commented Jun 26, 2018

That was fast! Seems like it's working great now. Replaced the plugin on my site, and the AMP version seems correct. Ran it through the validator, and seemed to be valid now.

@16patsle 16patsle closed this Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.